search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.27k stars 3.97k forks source link

Regular crashes in qbittorrent!sha1_block_data_order #16837

Open oorzkws opened 2 years ago

oorzkws commented 2 years ago

qBittorrent & operating system versions

qBittorrent: 4.4.2 qt5 x64 OS: Microsoft Windows Server 2022 Datacenter/10.0.20348 Build 20348 x64 Qt: 5.15.2 Libtorrent: 2.0.5.0 Boost: 1.78.0 OpenSSL: 1.1.1n zlib: 1.2.11

What is the problem?

qBittorrent is regularly (around every 8 hours) crashing without catching things in its own log. I had initially thought it was related to #11677 since the most recent message in the log was always the aforementioned i/o error however the latest crash was more than 30 minutes after the last log entry.

Steps to reproduce

  1. Load qBittorrent with a very very large amount of torrents (100k+?)
  2. Crashes start randomly occurring.

Additional context

I have followed the instructions given in https://github.com/qbittorrent/qBittorrent/issues/12064#issuecomment-592199677 - memory check and SFC come up fine. This happens while the machine is in use, and also happens while idle with no user around for hours. System stability has no issues otherwise, and I'm inclined to rule it out since the crash is always in the same place.

Log(s) & preferences file(s)

WinDbg Logs

qBittorrent logs give no indication, please let me know if the preference files are needed. I can provide the minidumps for all of the above crashes if necessary.

If this is a lib issue, I would appreciate assistance in choosing my next steps.

xavier2k6 commented 2 years ago

@oorzkws was there rechecking going on at the time?

I have encountered this sort of crash with CI build recently:

0XC0000005 qbittorrent!sha1_block_data_order+0x4c42 [C:\vcpkg\buildtrees\openssl\x64-windows-static-release-rel\crypto\sha\sha1-x86_64.asm @ 5691]

0XC0000006 qbittorrent!sha1_block_data_order+0x30c7 [C:\vcpkg\buildtrees\openssl\x64-windows-static-release-rel\crypto\sha\sha1-x86_64.asm @ 3885]

@Chocobo1 @glassez Thoughts? (static openssl/nasm issue?)

oorzkws commented 2 years ago

@oorzkws was there rechecking going on at the time?

Unlikely, but possible - I don't have any rechecking manually but duplicates could get added by RSS or some laggards rechecking very slowly after relaunch.

Chocobo1 commented 2 years ago

@Chocobo1 @glassez Thoughts? (static openssl/nasm issue?)

Can you provide full stack dump/backtraces? It is not sufficient to diagnosis the culprit currently. Also if it originates from libtorrent, you might also want to loop its maintainer in.

There were some bug reports on it, not sure which one could be related: https://github.com/openssl/openssl/issues?q=is%3Aissue+sha1_block_data_order+is%3Aclosed

xavier2k6 commented 2 years ago

stack trace is below (not really much to go on), there's also one in OP's opening post

(I have a ~4GB dump file too) qbittorrentPID8456Date07_07_2022__Time_10_30_02AM515Log.txt

Doing the environmental workaround has seemed to stopped the crashing (Haswell cpu)

luzpaz commented 2 months ago

@xavier2k6 can you still reproduce this ?