qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.18k stars 3.97k forks source link

[macOS] Enter key on numeric pad does not confirm dialogs #16904

Open esny23 opened 2 years ago

esny23 commented 2 years ago

qBittorrent & operating system versions

qbittorrent: v4.4.2 macOS: 10.14.6

What is the problem?

Enter key on numeric pad does not confirm dialogs. When I'm in the torrent download screen, and I press "enter" from the numeric keypad, it does not confirm the dialog. I have to press "return" from the standard keyboard portion. This issue occurred in the latest update in which the app icon changed. Previously the "enter" key would select "ok" and the screen would close and the download would begin.

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

luzpaz commented 1 year ago

@esny23 can you still reproduce on latest stable ?

luzpaz commented 1 year ago

Cursory research: https://stackoverflow.com/a/25637419

The Enter key referred to by Qt::Key_Enter is the Enter key on the numeric keypad. You are pressing the "Enter" key that's next to the letters on your keyboard. That's known as the Return key, and its value is represented by Qt::Key_Return, which equals 16777220.

https://github.com/search?q=repo%3Aqbittorrent%2FqBittorrent%20Qt%3A%3AKey_Return&type=code

githubjsorg commented 1 month ago

OS: Ubuntu 24.04.1 LTS qBit Version: 4.6.6 (the latest in the qBit repos)

Neither Enter or Return confirm torrent properties dialog. Instead you have to click the OK button or Alt+O.

This is a different behavior from previous versions (Ex. 4.5.5 - 4.6.5) which confirmed the dialog (same as clicking OK). The previous behavior is the standard UI behavior of Linux and Windows (don't know about others) for at least the last 20 years.

Even though this appears to be the same problem, if on a different OS, should I maybe create a new "issue" ticket?

thalieht commented 1 month ago

Neither Enter or Return confirm torrent properties dialog.

Can't reproduce in KDE. On 4.6.6.