search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
26.84k stars 3.87k forks source link

Weird behaviour in RSS Downloader #17316

Open wind77 opened 2 years ago

wind77 commented 2 years ago

qBittorrent & operating system versions

qBittorrent: 4.4.3.1 x64 Operating system: Manjaro Kernel 5.17.15-1 Qt: 6.3.0 libtorrent-rasterbar: 2.0.6

What is the problem?

In RSS Downloader, I set a rule to download particular source, and the rule is applied to 3 feeds. When the source is released to the 3 feeds by the same person, the titles of the RSS article across 3 feeds are, understandably, identical. Therefore, technically, as the 3 articles from different feeds are identical, they should be downloaded, as per the RSS download rule. However, only articles from 2 feeds are downloaded. When I check the "Unread" feed, the article was there, and when I double click to download, then the prompt would appear "Torrent is already in the transfer list. Trackers have been merged". I want to emphasize that:

  1. Across the 3 feeds, the title of the articles are the same.
  2. The un-downloaded article does not violate "must not contain" definition.
  3. In fact, when clicking "Download Rules" in RSS Downloader, the article does show up in "Matching RSS Articles".

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

glassez commented 2 years ago

When I check the "Unread" feed, the article was there, and when I double click to download, then the prompt would appear "Torrent is already in the transfer list. Trackers have been merged".

So what exactly is the problem? The same torrent cannot be added twice. Or is it the fact that article is not marked as "read"?

wind77 commented 2 years ago

So what exactly is the problem? The same torrent cannot be added twice. Or is it the fact that article is not marked as "read"?

technically, as the 3 articles from different feeds are identical, they should be downloaded, as per the RSS download rule. However, only articles from 2 feeds are downloaded.

wind77 commented 2 years ago
  1. The single identical article was released in 3 feeds, and was downloaded by RSS Downloader in 2 feeds. This means the article met the download criteria.
  2. If the 2 feeds were not "enabled", then the article won't be downloaded by RSS Downloader in the 3rd feed.
  3. This means: even though the article met the download criteria, it won't be downloaded by RSS Downloader.
  4. So is this behaviour expected? If not, won't u call it a "problem"?
glassez commented 2 years ago

So is this behaviour expected? If not, won't u call it a "problem"?

First of all, what do you mean by "article is downloaded" etc.? In fact, RSS Downloader tries to add a new torrent, the link to which the article contains. Even if a thousand articles link to the same torrent, it can only be added in a single copy. In theory, all these articles should be marked as "read". It is difficult for me to say exactly what is happening in your case without having specific data for testing/debugging (either the mentioned feeds, provided they are available to me, or downloaded data from these feeds that would have contained these "identical" articles).

wind77 commented 2 years ago

First of all, what do you mean by "article is downloaded" etc.?

"article is downloaded" = The magnet in the article is added to torrent list.

In fact, RSS Downloader tries to add a new torrent, the link to which the article contains. Even if a thousand articles link to the same torrent, it can only be added in a single copy. In theory, all these articles should be marked as "read".

You're getting there! Maybe it is simpler if i illustrate the scenario this way:

Download Rules: Must contain AB, Must not contain CD.

Feed 1: Article ABEF released. Downloader: Article ABEF fits download rules, add magnet to download list, mark Article ABEF as "read".

Feed 2: Article ABEF released. Downloader: Article ABEF fits download rules, add magnet to download list, mark Article ABEF as "read".

Feed 3: Article ABEF released. Downloader: Article ABEF fits download rules, magnet NOT added to download list, Article ABEF remained as "unread".

Download list: 1 torrent added.

Now, Feed 3 behaviour, is what I called "weird", and "a problem".

It is difficult for me to say exactly what is happening in your case without having specific data for testing/debugging (either the mentioned feeds, provided they are available to me, or downloaded data from these feeds that would have contained these "identical" articles).

Frankly, I understand your difficulties. Other than this behavior seems to focus on Feed 3, there is no specific pattern when the problem occurred. I notice this behavior happening more frequent, and now about 5% of the "unread" articles are actually "qualified" articles - they fulfilled the download rules, but not downloaded.

luzpaz commented 10 months ago

Need a more succinct title for this ticket