search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.76k stars 3.92k forks source link

UI shows 'wrong' download max speed on bottom status bar #17671

Open mushu999 opened 2 years ago

mushu999 commented 2 years ago

qBittorrent & operating system versions

qBitTorrent v4.4.5 (64-bit) Windows 10 pro 21H2 10.0.19044

qb3

What is the problem?

Bottom status bar appears to round the max Download (and probably Upload also) speed setting it displays in brackets when it goes over 999 kB/s. This looks weird because if you have the Upload max speed set to 999 kB/s or lower then it displays that exactly as you have in the settings screen. I would rather see it match what I entered than be "technically" correct by dividing my entry by 1024. This would also help newbies not be confused with "why is my download max always lower but my upload max matches my settings?"

qb2

qb1

Steps to reproduce

  1. enter a max speed over 999 kB/s
  2. go back to main qB window and view status bar
  3. profit!

Additional context

Perhaps it would be easier to just add a display to the right of the max speed entry field in the settings window of the value user enters divided by 1024 so at least that number will match what the bottom status bar displays?

Log(s) & preferences file(s)

No response

sledgehammer999 commented 2 years ago

1 MiB/s = 1024 KiB/s 3 MiB/s = 3072 KiB/s

mushu999 commented 2 years ago

Yes that's true but has nothing to do with the comment about the screen not matching. That's why I suggested they put the "real" value of whatever you enter in parens next to that field so it will match what the status bar shows. It's not immediately obvious that the 3000 (kB) you entered is 2.9 (MB) in reality. If it said 3MB that would match because verbally (say this part out loud) "3000 kilobytes equals 3 megabytes". I'm not explaining this right I guess...

Chocobo1 commented 2 years ago

I think this suggestion make sense, that is, always use the same unit (KiB/s) in speed limit widget (at the status bar) as in the Options/elsewhere.

glassez commented 2 years ago

I think this suggestion make sense, that is, always use the same unit (KiB/s) in speed limit widget (at the status bar) as in the Options/elsewhere.

The fact that the user can set limits using only one unit of measurement (KiB) is the problem of this particular place of the UI. IMO, it should not affect other places by deliberately making them worse. Something like 2.9 MiB/s [3000 KiB/s] looks bad and inconsistent. And it will annoy much more than the inconsistency between the units of different controls.

mushu999 commented 2 years ago

However, at least my post has shown a deficiency in the UI or at least a usability issue that should be corrected "somehow". Doesn't matter how really, just as long as things are consistent throughout the software.