qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.8k stars 3.93k forks source link

qbittorrent-nox 4.5.0 web UI cannot load Simplified Chinese. #18090

Closed hazaki520 closed 1 year ago

hazaki520 commented 1 year ago

qBittorrent & operating system versions

qBittorrent: 4.5.0 x64 nox Operating system: Arch Linux Qt:6.4.1 libtorrent-rasterbar: 2.0.8.0

What is the problem?

Simplified Chinese cannot be loaded after using pacman to upgrade to 4.5.0. After selecting Simplified Chinese to save, the page is still in English.

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

eUnisk commented 1 year ago

The same thing happened here. I'm using "binhex-qbittorrentvpn" docker on Unraid system.

brvphoenix commented 1 year ago

ping @sledgehammer999 @glassez This is caused by hardcoding language codes in JS and will be fixed by #17994. Can you guys review this pr?

userdocs commented 1 year ago

I build some debug nox builds with the patch people can test

https://github.com/userdocs/qbt_static_test/releases/tag/release-4.5.0_v2.0.8

https://github.com/userdocs/qbt_static_test/releases/tag/release-4.5.0_v1.2.18

Looked ok to me

image

Sowevo commented 1 year ago

This method can be used to temporarily process

RUANRUI1995 commented 1 year ago

same

RUANRUI1995 commented 1 year ago

Traditional Chinese is ok.Simplified Chinese is not.

RUANRUI1995 commented 1 year ago

windows client same problem

brvphoenix commented 1 year ago

This issue is caused by 27a69d9cca1003e8099395a1aaa2f4ab91b017be (06c4c5861349c3cea948c384ea2043dbd686deb3 on master branch). It only affect the language setting with Simplified Chinese.

A simple fix is

@@ -719,7 +719,7 @@
             <option value="uk_UA">Українська</option>
             <option value="uz@Latn">أۇزبېك</option>
             <option value="vi_VN">Tiếng Việt</option>
-            <option value="zh">简体中文</option>
+            <option value="zh_CN">简体中文</option>
             <option value="zh_HK">香港正體字</option>
             <option value="zh_TW">正體中文</option>
         </select>

With #17994, all the similar issues can be avoided.

windows client same problem

This issue only affects clients using the WebUI. With the GUI client, you need switch to another language, then switch back and save settings.

tobylibo commented 1 year ago

I have the same problem.

AkarinLiu commented 1 year ago

Linuxserver.io version:- 4.5.0-r1-ls241 Build-date:- 2023-01-22T21:48:31-06:00 image

hazaki520 commented 1 year ago

Version 4.5.1 has fixed this issue