qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
25.96k stars 3.82k forks source link

qBittorrent 4.5.0 "Stalled" colour #18123

Open corobin opened 1 year ago

corobin commented 1 year ago

qBittorrent & operating system versions

qBittorrent: 4.5.0 x64 Operating system: Windows 10 x64 (10.0.1xxxx) Qt: 5.15.7

What is the problem?

On 4.5 the "Stalled" colour has been changed to light green while the downloading colour is a darker green. In previous versions, "Stalled" was not coloured extremely similar to the active torrent.

Now it is very difficult to tell at a glance the difference between an active download and a stalled one, this will be even worse if the user has poor colour reproduction on their monitor.

Steps to reproduce

  1. add a torrent that stalls
  2. look at it

Additional context

Suggested fix: please revert to old "stalled" colour

Log(s) & preferences file(s)

No response

MrxHellsing commented 1 year ago

Doesn't it show in the status column? I'm using v4.5.0alpha1 btw image

MrxHellsing commented 1 year ago

@PriitUring not a typo, that build was given in this issue #17603 . Your screenshot looks to have a quite a lot going on, so not gonna weigh in on that. I don't run qbit with that many features turned on, so my assumption was the new stable version might have the stats turned off or removed somehow and for me, it didn't make any sense since the official build is 4.5 now and I was running the preview version given by members of the dev team to tackle to freezing issue. Hence the suggestion to the OP that stalled and downloading should have been visible from the status column.

Symbai commented 1 year ago

18078

xavier2k6 commented 1 year ago

@corobin In previous versions of qBittorrent - Stalled Downloading & Stalled Uploading shared the same icon & text color (black on a white background/white if on black background) even though they represented different torrent states.

This was changed in 4.5.0 so that each torrent state could be more easily identified/distinguished or at least be visually representative on what child torrent state would be associated with it's parent torrent state.

For comparison, below is two screenshots - both showing with a Stalled Torrent Status in Transfer List.

FYI: The "naming" columns in the transfer list (which display icons too) etc. were disabled here to better represent where I'm coming from & the Status Filters List has been resized.

Screenshot 1:

qBittorrent "stalled" <=4.4.5:

stalled_old

Screenshot 2:

qBittorrent "stalled" =4.5.0:

stalled new
corobin commented 1 year ago

@xavier2k6 at a glance which one is stalled and which one is running?

demo

xavier2k6 commented 1 year ago

Left side (4.5.0): 2.14 GiB - green = downloading/forced downloading 4.37 GiB - light green = stalled downloading 7.53 GiB - grey = paused

Right side (<=4.4.5): 4.37 GiB - black = stalled downloading or stalled uploading (these two torrent states weren't differentiated as I've said before) 7.53 GiB - salmon = paused 2.14 GiB - green = downloading/forced downloading

(I didn't have the benefit of the status filter like the screenshots that were provided to you to compare the text color to the associated icon in the list.)

Now....I'm not saying that text colors are perfect in official 4.5.0, there are some duplicated etc but these are being/will be rectified.

My initial steps to differentiate torrent state colors can be seen in https://github.com/qbittorrent/qBittorrent/issues/18078#issuecomment-1328851772 & as was stated there, these got changed afterwards but the text colors weren't matched up 100%.

Pentaphon commented 1 year ago

2.14 GiB - green = downloading/forced downloading 4.37 GiB - light green = stalled downloading

You have to admit, its not easy to tell the difference between green and light green on a white background. Stalled is not nearly the same as downloading so it shouldn't even have the same color, regardless of shade. Stalled means something is wrong with the download and it should have a color to reflect that like red, orange, or yellow aka colors that require immediate attention.

whitebear60 commented 1 year ago

The same applies for stalled uploading torrents... Imo, either colour of the working torrents should be darker, or colour of the stalled torrents should be lighter... (probably with the latter it would be harder to read the text though, if it would be too light...)