search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.12k stars 3.9k forks source link

multiple lines can be selected/focused (torrent list) #18294

Open b-user opened 1 year ago

b-user commented 1 year ago

qBittorrent & operating system versions

qBittorrent: 4.5.0 x64 Operating system: Windows 11 (10.0.22xxx) Qt: 6.4.0

What is the problem?

sometimes multiple lines can be selected

Steps to reproduce

  1. add 1.torrent (dont start)
  2. add 2.torrent (dont start)
  3. click ("1" as in the picture)
  4. click ("2" as in the picture)
  5. click ("3" as in the picture)
  6. click ("4" as in the picture) double selected_click

result: two lines are selected double selected

EXPECTED result: one line are selected EXPECTED

Additional context

multiple lines can be focused: multi

No response

Log(s) & preferences file(s)

No response

thalieht commented 1 year ago

Only the last line remain selected for me on the next transfer list refresh. It only happens when the subsequent selections are below the last one so I think it's a Qt problem.

b-user commented 1 year ago

there is no such bug with the selection in the "trackers" tab. not-qt-bug2 please remove the label "Qt bugs" because it doesn't look like a "qt bug"

glassez commented 1 year ago

please remove the label "Qt bugs" because it doesn't look like a "qt bug"

Then what does it look like to you?

b-user commented 1 year ago

In my opinion, it looks like a miscalculation in event processing.

glassez commented 1 year ago

In my opinion, it looks like a miscalculation in event processing.

So do you think that this is handled at the application level itself, and not by Qt?

b-user commented 1 year ago

I assume it's in the qBittorrent code. If I thought otherwise, I wouldn't have written "because it doesn't look like a "qt bug"". If you have any reason to say otherwise, say so.

At the moment, I only see such a bug in the torrent tab, and there is no bug in the tracker tab. That's why I made such an assumption.

There are bugs in qt that haven't been fixed for years. But this case is not very similar. At least at first glance.

thalieht commented 1 year ago

I tested official 4.2.1 (Qt 5.13.2) (oldest version with support for "profile" folder portable mode) and problem existed back then. I was looking for when transferlist changed to use QStyledItemDelegate (i have no idea if it could be relevant) and luckily that was in 4.2.2.

glassez commented 1 year ago

BTW, multiple items really only look like "focused/selected".

b-user commented 1 year ago

I tested official 4.2.1 (Qt 5.13.2) (oldest version with support for "profile" folder portable mode) and problem existed back then

qbittorrent_4.2.0 - problem existed qbittorrent_4.1.9.1 - problem "don`t"* existed

*it looks like in 4.1.9.1 (4.0.0 .. 4.1.9.1) there was workarround forcibly updating these fields about once a second.