search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.07k stars 3.9k forks source link

Parts of UI not updated when Windows High Contrast theme is enabled #18315

Closed AdKiller closed 1 month ago

AdKiller commented 1 year ago

qBittorrent & operating system versions

qBittorrent: 4.5.0 x64 Operating system: Windows 10 Pro 22H2/19045 x64 (10.0.19045) Qt: 6.4.0 libtorrent-rasterbar: 2.0.8.0

What is the problem?

Status bar & Filters sidebar text are not updated correctly when Windows High Contrast theme is enabled.

Steps to reproduce

  1. Open qBittorrent (with default Windows theme)
  2. Enable Windows High Contrast theme

Additional context

qbt bug after HC

All parts of qBittorrent v4.3.9 UI correctly changes after enabling high contrast theme.

Work around: Disabling and enabling Status bar & Filters Side bar in View menu updates the text colors correctly, however, in filters sidebar number of Error & Warning under Tracker goes to zero even if they were not zero before enabling high contrast theme.

Log(s) & preferences file(s)

No response

xavier2k6 commented 1 year ago

All parts of qBittorrent v4.3.9 UI correctly changes after enabling high contrast theme.

👍 This appears to be only with the use of Qt6 Series (from preliminary testing) or at least it brings the issue to the forefront...I've observed this type of behaviour previously & mentioned it in some PR.

in filters sidebar number of Error & Warning under Tracker goes to zero even if they were not zero before enabling high contrast theme.

@AdKiller Can you create a separate issue for this please.

AdKiller commented 1 year ago

Still not fixed in v4.5.2. This problem did not exist in previous versions. It is simple but very annoying! Please fix it.

glassez commented 1 year ago

qBittorrent has never officially supported any dark themes on Windows, much less switching between color modes on the fly. It worked as much as Qt allowed us to do it without additional care on our part. Since Qt has improved support for dark mode in Windows in latest versions (6.4 and 6.5), and users really want it, I recently started working on improving compatibility with dark mode.

glassez commented 1 year ago

This appears to be only with the use of Qt6 Series

I haven't tested this with Qt5, but I noticed it recently when I started improving dark mode support on Windows with Qt6. According to my observations, those widgets to which the style sheet is applied cannot handle changing the color mode on the fly (until application is restarted). I believe this is some kind of Qt regression, however, I still want to get rid of using style sheets as much as possible.

luzpaz commented 10 months ago

Is this still relevant?

AdKiller commented 10 months ago

Is this still relevant?

Yes. exact same problem happens in v4.6.0 qBittorrent Windows x64 (lt20 qt6)

xavier2k6 commented 10 months ago

  1. Filters Sidebar text not being visible was resolved IIRC.

  2. Status bar text not being visible is still an issue even in master (switching between light/dark mode isn't possible currently at run-time)

13xforever commented 5 months ago

Now that 5.0b1 is somewhat officially supporting dark theme on windows, maybe someone will fix the base text color in transfers list and rss tab after switching light/dark mode in runtime

luzpaz commented 1 month ago

What's left here ?

xavier2k6 commented 1 month ago
  1. Filters Sidebar text not being visible was resolved IIRC.
  2. Status bar text not being visible is still an issue even in master (switching between light/dark mode isn't possible currently at run-time)

Both issues have since been resolved along with other runtime switching issues & will be in official v5.0