search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.42k stars 3.9k forks source link

Slow Torrents Bug #18948

Open vault-thirteen opened 1 year ago

vault-thirteen commented 1 year ago

qBittorrent & operating system versions

qBittorrent: 4.5.2 x64 Operating system: Windows 10 Pro 22H2 (10.0.19045) x64 Qt: 5.15.8 Libtorrent: 1.2.18.0

What is the problem?

When I enable the "Do not count slow torrents in these limits" setting in the "BitTorrent" section of Options, the client goes crazy. What does it mean ? The client just starts downloading all the torrents available in the queue ignorring all the limits.

Steps to reproduce

  1. Enable the "TorrentQueueing" in the "BitTorrent" section of Options.
  2. Limit the number of active torrents by setting the "Maximum active downloads" setting to some value like 2 or 3.
  3. Add a lot of torrents to the list, much more than 2 or 3.
  4. Start downloading all the torrents. You will see that only 2 or 3 torrents are being actively downloaded as per the setting.
  5. Now the fun starts. Enable the slow torrents counter by checking the "Do not count slow torrents in these limits" settings in the "BitTorrent" section of Options. Also, set the speed threshold for slow torrents to something like 20 KiB/s for download, set the inactivity timer to 60 sec.
  6. When you apply the settings mentioned above, the client goes crazy and starts downloading all the torrents in the list, ignorring the "Maximum active downloads" setting set earlier.

Additional context

No response

Log(s) & preferences file(s)

No response

vault-thirteen commented 1 year ago

It bypasses that limit, because you enabled: "Do not count slow torrents in these limits".

Then why did earlier versions of qBittorrent (the v4.4.x series) not bypass this limit ?

thalieht commented 1 year ago

Then why did earlier versions of qBittorrent (the v4.4.x series) not bypass this limit ?

It didn't and still doesn't bypass the "Maximum active torrents" limit. Bypassing the other 2 limits is the whole point of this setting.

vault-thirteen commented 1 year ago

It didn't and still doesn't bypass the "Maximum active torrents" limit.

Why are you telling this when in the previous comment PriitUring said that modern version of the client bypasses the limit and I see that it bypasses it with my own eyes ? I do not understand it.

4.4.x versions of qBittorent worked normally. 4.5.x versions of qBittorrent are working not normally.

I will have to switch to some other clients for BitTorrent protocol due to this "feature".

thalieht commented 1 year ago

Why are you telling this when in the previous comment PriitUring said that modern version of the client bypasses the limit and I see that it bypasses it with my own eyes ? I do not understand it.

Pay attention to the bold part, here, now in capitals too:

It didn't and still doesn't bypass the "Maximum active TORRENTS" limit.

and now compare that to your step 2 and hopefully you'll realize why "it worked before" but now "it has a bug".

vault-thirteen commented 1 year ago

I see. When I switched the "slow torrents" feature on in old versions of qBittorrent client, I did not see such a behaviour. All thousands of torrents were not started all at the same time for some reason. Why was it so ? Can you tell what has changed ?

thalieht commented 1 year ago

torrents were not started all at the same time

Apologies, you are right. What i was saying is a common misunderstanding so i assumed this was it but now that you said "at the same time" i actually tested it and i can reproduce.

thalieht commented 1 year ago

4.4.x versions of qBittorent worked normally.

Then it's a libtorrent bug because i now compiled 4.4.4 and 4.4.0 with libtorrent 2.0.8 and they have this problem.