qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.62k stars 3.91k forks source link

Search plugins not found #1956

Closed sledgehammer999 closed 10 years ago

sledgehammer999 commented 10 years ago

After the release of v3.1.10 the search plugins aren't found by qbt. If you invoke the scripts from cmd using python they work. Not all users seem to experience this problem.

Some relevant comments in here: https://github.com/qbittorrent/qBittorrent/pull/1951

sandrocosta commented 10 years ago

My Search Engines disappeared too from "Search Plugins" box after I update to 3.1.1 version, as the search categories!

sledgehammer999 commented 10 years ago

I update to 3.1.1 version

I suppose you mean 3.1.10. Because 3.1.1 is a different version.

Do you use Windows or Linux? (and which version)

sandrocosta commented 10 years ago

Sorry. I meant 3.1.10 I use Windows 7, 64 bit. I went back to version 3.1.8 (I haven't downloaded the 3.1.9!).

Sandro.

2014-09-25 16:57 GMT-03:00 sledgehammer999 notifications@github.com:

I update to 3.1.1 version

I suppose you mean 3.1.10. Because 3.1.1 is a different version.

Do you use Windows or Linux? (and which version)

— Reply to this email directly or view it on GitHub https://github.com/qbittorrent/qBittorrent/issues/1956#issuecomment-56874436 .

sledgehammer999 commented 10 years ago

You can find all the versions here: http://sourceforge.net/projects/qbittorrent/files/qbittorrent-win32/ (better use 3.1.9.2)

sandrocosta commented 10 years ago

Thank you. Are there any plans to fix the 3.1.10 version? Sandro.

2014-09-25 17:47 GMT-03:00 sledgehammer999 notifications@github.com:

You can find all the version here: http://sourceforge.net/projects/qbittorrent/files/qbittorrent-win32/ (better use 3.1.9.2)

— Reply to this email directly or view it on GitHub https://github.com/qbittorrent/qBittorrent/issues/1956#issuecomment-56881489 .

sledgehammer999 commented 10 years ago

It's marked for a possible v3.1.11. Otherwise for v3.2.0 I don't have an ETA though.

DoumanAsh commented 10 years ago

If it is not too difficult please correct import in legittorrents.py in nova3 import sgmllib -> import sgmllib3

sledgehammer999 commented 10 years ago

import sgmllib -> import sgmllib3

Are you sure that that is correct? I am not a python programmer so I am asking you.

DoumanAsh commented 10 years ago

Python 3 has no module sgmllib. It is not seen because excpetions are ignored. If you'll check exceptions with python 3:

ImportError: No module named 'sgmllib'

Replace it with sgmllib3 and now legittorrents is fine As i can see in nova3 there is also sgmllib3.py so i guess this is replacement for removed sgmllib

sledgehammer999 commented 10 years ago

That makes sense. I'll do it after I fix the main issue here.

krader1961 commented 10 years ago

No, you cannot simply change that line to "import sgmllib3". That's because the name of the module is used to create a namespace for the constituents of the module. In this case you can either change the line to

import sgmllib3 as sgmllib

Or do the simple import without the "as" clause and replace the references to sgmllib.SGMLParser in .../nova3/engines/legittorrents.py to sgmllib3.SGMLParser.

Also, the sgmllib module isn't being actively maintained, has been deprecated for several years, and was dropped from the standard python library with the release of python3. It would be a good idea to switch to the standard html.parser module (or pretty much anything that isn't sgmllib).

sledgehammer999 commented 10 years ago

Currently the team doesn't have any python dev. So I only try to do really basic maintenance stuff while looking at the online python docs.

If you have experience in python and time, any patches are welcome. (do git pull requests)

DoumanAsh commented 10 years ago

krader1961, Yes you just need to replace all sgmllib as sgmllib3 in code(work just fine) I guess i was need to be more clear...

sledgehammer999, Right now i'm playing with own search engine, once i will get a firm grip of how to do that i can help to rewrite existing plugins. Though i actually not a python dev at all :D

deenbee commented 10 years ago

Yes, I am use qbit 3.1.10 in ubuntu work perfect but today I installed on win 7 x64 the search plugins are empty.

filocullen commented 10 years ago

Hi, im using windows 8.1, and I have the same problem, i downloaded the 3.1.10 version, and I can't find any search engines, I'm not an expert, what can I do?thanks

sledgehammer999 commented 10 years ago

what can I do?

Read the bug report. There isn't a solution. When I fix it I'll make a new release for this. For the meantime if you want revert back to 3.1.9.2

BrunoReX commented 10 years ago

Okay, I noticed a couple things.

Both are fixed by https://github.com/qbittorrent/qBittorrent/commit/b47fba49cce0a15711482f5ce520d1ed4e65c7be

deenbee commented 10 years ago

I try install Python 2.7 & 3.4 in default path install directory, nothing work in Windows 7 x64, in Ubuntu work perfect.

212eta commented 10 years ago

-Although v3.1.10 was available, the 'Help>Check for updates' of v3.1.9.2 assured me that there was no update available...

-I installed v3.1.10 over v3.1.9.2 on Windows 8.1 x64.

-Unfortunately, all my Search plugins lost!!!

-Therefore, I reverted back to 3.1.9.2 and had to install my Search plugins again!!!

sledgehammer999 commented 10 years ago

-Although v3.1.10 was available, the 'Help>Check for updates' of v3.1.9.2

We know about it: https://github.com/qbittorrent/qBittorrent/issues/1954

  • * It would be wise to Test -Before- Publicly/Officially releasing a New version * * *

I do minimal testing ie I test that you can actually download a torrent with the program. That is it's main function. I cannot test EVERY aspect of the program. If you want that kind of service you should try some paid program. I do my best with the resources I have available(time and money).

sledgehammer999 commented 10 years ago

I think commit https://github.com/qbittorrent/qBittorrent/commit/b47fba49cce0a15711482f5ce520d1ed4e65c7be has already fixed this issue. Can you guys try this temp build and tell me if it works? -> http://builds.shiki.hu/temp/qbittorrent_3.1.1020141004_setup.exe

sandrocosta commented 10 years ago

It's working fine. Sandro.

2014-10-04 16:23 GMT-03:00 sledgehammer999 notifications@github.com:

I think commit b47fba4 https://github.com/qbittorrent/qBittorrent/commit/b47fba49cce0a15711482f5ce520d1ed4e65c7be has already fixed this issue. Can you guys try this temp build and tell me if it works? -> http://builds.shiki.hu/temp/qbittorrent_3.1.1020141004_setup.exe

— Reply to this email directly or view it on GitHub https://github.com/qbittorrent/qBittorrent/issues/1956#issuecomment-57915761 .

deenbee commented 10 years ago

Yes sledgehammer999, has been fixed now working in windows 8 x64. thanks

sledgehammer999 commented 10 years ago

@BrunoReX I totally missed your comment saying that it was fixed by that specific commit. Now I'll for one more confirmation by someone else. Otherwise I'll close this tomorrow.

deenbee commented 10 years ago

Yes @BrunoReX the new temp version fixed by @sledgehammer999 putting in the forum now work.

(http://builds.shiki.hu/temp/qbittorrent_3.1.1020141004_setup.exe)

sandrocosta commented 10 years ago

The issue of search engines has been resolved. But unfortunately the program has been terminated unexpectedly several times. It may be my PC, but that did not happen before!

2014-10-04 19:46 GMT-03:00 Danubio notifications@github.com:

Yes @BrunoReX https://github.com/BrunoReX the new version than fixed by @sledgehammer999 https://github.com/sledgehammer999 put in the forum that's work

— Reply to this email directly or view it on GitHub https://github.com/qbittorrent/qBittorrent/issues/1956#issuecomment-57920879 .

meinbits commented 10 years ago

Hi, the temp looks works fine, thanks to all for your time! =)