qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.03k stars 3.95k forks source link

Bump CMake Minimum Requirement in `master` to be inline with/exceed Qt 6.6+ macOS Requirements #20460

Open xavier2k6 opened 8 months ago

xavier2k6 commented 8 months ago

qBittorrent & operating system versions

qBittorrent: master

What is the problem?

Currently CMake 3.16 is Min. Req. https://github.com/qbittorrent/qBittorrent/blob/7786e1b084c5534f757cd762f328b0ed242f5375/CMakeLists.txt#L1


(As of Qt 6.6) - The minimum CMake version for Qt on Apple platforms is now CMake 3.21.1.

Bump CMake requirements on Apple platforms The minimum CMake version for Qt on Apple platforms is now 3.21.1.

https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.6.0/release-note.md


CMake (>= 3.16, >= 3.18.4 for Ninja Multi-Config, >= 3.19 for WebEngine, >= 3.21.1 for static Qt builds in Qt 6.2+, or builds for Apple platforms in Qt 6.6+)

https://wiki.qt.io/Building_Qt_6_from_Git


CMake (>=3.16, >= 3.18.4 for Ninja Multi-Config, >= 3.21.1 for static Qt builds or building for Apple platforms)

https://doc.qt.io/qt-6/macos-building.html

Steps to reproduce

No response

Additional context

https://repology.org/project/cmake/badges https://www.scivision.dev/cmake-changelog/

Log(s) & preferences file(s)

No response

xavier2k6 commented 2 months ago

@qbittorrent/bug-handlers Thoughts? - Is there anything else required other than just bumping the minimum version?