qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.05k stars 3.96k forks source link

qBittorrent and far2l-wx clipboard interaction not working on Wayland #20547

Closed unxed closed 7 months ago

unxed commented 7 months ago

qBittorrent & operating system versions

Ubuntu 23.10, qBittorrent 4.5.4 from default repo.

What is the problem?

On Ubuntu 23.10 in Wayland session you can't copy text from qBittorrent to far2l (Far Manager Linux port) GUI (wxWidgets-based) version.

The reason is that qBittorrent expose text only astext/plain;charset=utf-8, but wxWidgets only understand STRING and UTF8_STRING in some aspects of its clipboard API.

Please add support for UTF8_STRING format also.

Steps to reproduce

Help - About - Special thanks - copy any text - try to paste to far2l wxWidgets GUI.

Additional context

See also: https://github.com/elfmz/far2l/issues/2053 https://github.com/wxWidgets/wxWidgets/issues/24391#issuecomment-1989195956 https://github.com/telegramdesktop/tdesktop/issues/27569 https://bugreports.qt.io/browse/QTBUG-123176 https://github.com/rickyrockrat/parcellite/issues/89 https://gitlab.gnome.org/GNOME/gnome-text-editor/-/issues/657 https://bugs.kde.org/show_bug.cgi?id=483459

Log(s) & preferences file(s)

No response

sledgehammer999 commented 7 months ago

This seems to me like a toolkit problem. And since Qt/Gtk work under Wayland correctly it is probably a responsibility of wxWidgets to work too. Also from scattered info on the net it seems that the STRING and UTF8_STRING targets are X11 targets.

I am inclined to closing this, unless other members have better insight on this.

unxed commented 7 months ago

Can you please point me to docs describing X11 and Wayland targets?

Would it be ok to just replace "STRING" with "text/plain" in wx if WAYLAND_DISPLAY env var is present and is set to non empty value?

sledgehammer999 commented 7 months ago

I don't have concrete info. Just a quick google search and scattered info. You should look up the clipboard protocols for X11 and Wayland. You might find the answer there. Or wait a fix from the wx devs (or answers from the Qt/Gtk people).

sledgehammer999 commented 7 months ago

Closing because it seems to be a wxWidgets issue, as evidenced by https://github.com/wxWidgets/wxWidgets/pull/24423