search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
26.97k stars 3.88k forks source link

qbittorrent 5.0 beta 1 Windows "colour theme" ( dark/light ) switching issue #21120

Open IlgazC opened 1 month ago

IlgazC commented 1 month ago

qBittorrent & operating system versions

qBittorrent: 5.0 beta 1 Operating System: Windows 11 23H2 (OS Build 22631.3958) Qt: 6.6.2 Libtorrent: 2.0.11.0 Boost: 1.84.0 OpenSSL: 3.2.1 zlib: 1.3.1

What is the problem?

I keep the application open 24/7 and during my normal usage, I switch to "light" colour theme of Windows in daytime. When I do switch to light one, I noticed the statistics/speed on right bottom are almost impossible to read "white" font on gray area. qb

Steps to reproduce

1) Run qbittorrent in Windows dark mode 2) Switch to light mode 3) See the stats on right bottom, they will be white on gray.

Additional context

I suspect it is a Qt framework issue.

Log(s) & preferences file(s)

qBittorrent_ini_files.zip

xavier2k6 commented 1 month ago

@glassez This was already resolved, if you remember - the work around at the time was to disable the status bar/re-enable it.

We had a similar situation with filters bar etc,

I currently don't recall what PR/commit fixed it.

There are still a few light/dark runtime switching issues in both GUI/WebUI in master - I will open tickets for these.

glassez commented 1 month ago

There are still a few light/dark runtime switching issues in both GUI/WebUI in master - I will open tickets for these.

Please separate Issues for GUI and WebUI since they would require different solutions.

xavier2k6 commented 1 month ago

Please separate Issues for GUI and WebUI since they would require different solutions.

Making a start.....e.g. #21155

glassez commented 1 month ago

Steps to reproduce

  1. Run qbittorrent in Windows dark mode
  2. Switch to light mode
  3. See the stats on right bottom, they will be white on gray.

Additional context

I suspect it is a Qt framework issue.

I did not notice such a problem when using the current master build using Qt 6.7.2.

xavier2k6 commented 1 month ago

@glassez This was already resolved, if you remember - the work around at the time was to disable the status bar/re-enable it.

We had a similar situation with filters bar etc,

I currently don't recall what PR/commit fixed it.

https://github.com/qbittorrent/qBittorrent/issues/21120#issuecomment-2254452492

glassez commented 1 month ago

@glassez This was already resolved, if you remember - the work around at the time was to disable the status bar/re-enable it.

We had a similar situation with filters bar etc,

I currently don't recall what PR/commit fixed it.

So 5.0 beta is too old and doesn't include these fixes?.. Damn, it's really inconvenient to work with such a slow release cycle...

xavier2k6 commented 1 month ago

So 5.0 beta is too old and doesn't include these fixes?..

That's correct, it only seemed to have been fixed via https://github.com/qbittorrent/qBittorrent/pull/20569 & another issue was resolved in https://github.com/qbittorrent/qBittorrent/pull/20588

EDIT: I don't think they got backported from master to v5.0.x branch.