search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.45k stars 4k forks source link

Current iconset relies too much on Blue icons. We need more variety by using icon colors other than Blue or using 2 or more colors per icon. #21449

Open Pentaphon opened 1 month ago

Pentaphon commented 1 month ago

We need less blue icons and more variation in icons to make them more distinct. As you can see, the current iconset relies too much on blue icons. Does the mail envelope need to be blue? Does the settings gear need to be blue? Does the torrent creator icon need to be blue? We need to use more colors and have more icons like the torrent creator icon use 2 more or more colors.

{98535517-8D96-4B73-987D-10C9E7A01AC8}

glassez commented 1 month ago

This and similar problems will not get off the ground until someone interested suggests a PR and maintain it until it is merged.

Pentaphon commented 1 month ago

This and similar problems will not get off the ground until someone interested suggests a PR and maintain it until it is merged.

I know. The main issue we have is that nobody wants to do a total theme revamp because it is such a huge project to create from scratch. Therefore, I decided to instead create 2 issues that are more realistic to solve. This issue can realistically be pushed in time for 5.1.0. It simply involves changing as many of the blue icons we currently have to other colors.

I think this and https://github.com/qbittorrent/qBittorrent/issues/21448 are the 2 biggest issues that can be addressed without needing a total theme revamp so I made them in the event somebody sees them and does at least 1 or both of them.

Mazino-Urek commented 1 month ago

This and similar problems will not get off the ground until someone interested suggests a PR and maintain it until it is merged.

The first step would be creating two icon folder. One for dark and the other for the light theme. As I am not a developer I can't do that. If anyone can implement that first, I can gradually change the colors of the icon.

However, I can't make massive one PR change like last time. I

glassez commented 1 month ago

The first step would be creating two icon folder. One for dark and the other for the light theme. As I am not a developer I can't do that. If anyone can implement that first, I can gradually change the colors of the icon.

It is available. You can start by using "Customize UI theme" feature even without recompiling your qBittorrent.

Mazino-Urek commented 1 month ago

The first step would be creating two icon folder. One for dark and the other for the light theme. As I am not a developer I can't do that. If anyone can implement that first, I can gradually change the colors of the icon.

It is available. You can start by using "Customize UI theme" feature even without recompiling your qBittorrent.

I use that option. What I am trying to say is, rather than pulling all icons from /src/icons. There will be two individual folder inside the icons folder.

Example:

/src/icons/dark and /src/icons/light

When a user selects the dark theme icon will be pulled from /src/icons/dark and in the case of light theme vice versa.

In that way, I can tune each theme icon in such a way that it is not offensive to the eyes. In my opinion, Apple has already done a great job and by using the color schemes from the color palette below can resolve the issue.

image

glassez commented 1 month ago

What I am trying to say is, rather than pulling all icons from /src/icons. There will be two individual folder inside the icons folder.

Example:

/src/icons/dark and /src/icons/light

This is also available. The only difference is that light mode (default) icons are searched in the icons root folder (/src/icons), and dark mode icons in the dark subfolder (/src/icons/dark).

Mazino-Urek commented 1 month ago

This is also available. The only difference is that light mode (default) icons are searched in the icons root folder (/src/icons), and dark mode icons in the dark subfolder (/src/icons/dark).

There is no physical folder in the source code. It is probably done via code, I guess. image

glassez commented 1 month ago

There is no physical folder in the source code. It is probably done via code, I guess.

Sure. There was no point in creating this folder, since we didn't have separate icons for the dark mode. Besides, I'm not sure if Git supports empty folders in the repository.

andriybogachev commented 1 month ago

The dark theme is terrible and it's forced if you have a dark theme on windows. It was necessary to make a separate theme switcher in the settings and not to automatically pull it up from the system!