qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.89k stars 3.94k forks source link

A better update method #21454

Open alexandremix opened 3 weeks ago

alexandremix commented 3 weeks ago

Suggestion

https://github.com/qbittorrent/qBittorrent/issues/21452 Ive written the comments here, but ill explain again.

Basically the way the update is right now kinda gives the user the impression that the download was broken or something was wrong.

Why? Well the normal procedure of everyone is: Update window appears, we click download, then we try to install. (we dont remember to close the qbittorrent) A windows error appears that the file cant be copied to try again or ignore that specific file.

If we ignore the file we might even run the risk of having an corrupted install.

What we should have: Several options: The installer can try to do CTRL+Q to close the software and then qBittorrent tries to close itself as normal and can prompt users the normal warnings that already does (For eg: Theres downloads running are you really sure?)

OR: if sledgehammer999 does not like that the software closes "automatically" without the user "consent" on the installer he can add a checkbox that the user clicks: "Attempt to close qBittorrent if running" that would do that.

OR, if he really wants the user to having to close the software, at least present a warning that the software is running before installing so any user can really understand what is going on. instead of that windows error mid install.

Several choices:

-When installing the software closes Automatically as CTRL+Q on bittorrent, if user is presented with any warning he can decide if indeed he wants to close or not. -Add a box on the installer so the user asks the installer to do the closing for him. -Make the error happen before the install clearly stating that the software is running

Use case

No response

Extra info/examples/attachments

No response

tuxayo commented 3 weeks ago

@alexandremix : proposal: edit the ticket to remove the unnecessary thing about the maintainer's morals. For the sake of keeping the 3 proposals which are totally worth discussing:

Plus reword "he can add a checkbox". There is no place to directly ask someone in particular to implement something.

The 3 ideas have merit and the 1st step is whether one, two or the three are desirable. (i.e. a well made patch implementing them would likely be accepted) When it's done then it's about these one or multiple retained proposals being open to be implemented by anyone having the time and will do to it. No one in particular.

alexandremix commented 3 weeks ago

I added the morals stuff, because all the tickets about the update process are being automatically closed by mentioning the comment made by that dev.

And by reading more i understood that the only reason for it to be like that its because theres something that he does not like about it being automatic because companies change stuff without users kinda knowing it.

I didnt quite understand, just wanted the ticket to have a chance.

Also The CTRL+Q is my way of saying that the software just closes itself by its normal exiting methods instead of force closing it. To prevent saying that everything will be broken etc. As it was happening on my first ticket.

sledgehammer999 commented 3 weeks ago

Don't you get the following picture? If I run the installer while qbittorrent is running I get this:

Untitled1
HananKrishna commented 3 weeks ago

@sledgehammer999 Do any of the options on the dialog box allow the user to close said qBit client within said dialog box instead of making the user manually close the qBit client?