qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.49k stars 3.91k forks source link

qBittorrent-nox moves removed torrent data to .Trash by default #21497

Open Generator opened 4 days ago

Generator commented 4 days ago

qBittorrent & operating system versions

qBittorrent: v5.0.0 Docker: qbittorrentofficial/qbittorrent-nox

What is the problem?

When using qbittorrent-nox if the user removes a torrent with "Also remove the content files" instead of deleting the torrent files, it creates and moves to .Trash-GID.

On a headless system, there's no trash-bin so the user won't notice that the files still on the system.
Many users use *arr apps to automate the downloads, it can take a long till notice the issue.

Steps to reproduce

  1. Run qbittorrent-nox from system or docker docker run --rm -it -v ./downloads:/downloads -p 8080:8080 qbittorrentofficial/qbittorrent-nox:latest
  2. Add torrent (e.g Ubuntu) and let download partial or complete.
  3. Remove torrent with "Also remove the content files"

Additional context

There's no warning or "visible option" to notify the user from WebUI that the files aren't delete from the system, but instead moved to .Trash.

The option to permanent delete files on Advanced settings ("Torrent content removing mode"), which many user don't event look or mess with it.

qbittorrent-nox build should always delete files by default specially on headless systems.

Log(s) & preferences file(s)

qBittorrent.conf.txt qbittorrent.log

slrslr commented 3 days ago

https://github.com/qbittorrent/docker-qbittorrent-nox I am not having -nox, but regular 5.0.0 lt2 .AppImage on a desktop PC (I am NOT using WebUI) and i can reproduce the file trashing only in case i delete torrent with one file as a payload. When the torrent has a folder and a file in its payload, then it deletes it permanently...

Ofearghail commented 3 days ago

https://www.reddit.com/r/qBittorrent/comments/1b1eyx8/faq_sticky_help_post/

If you are using WebUI, you can edit the .ini file. Under [BitTorrent], add this line: Session\TorrentContentRemoveOption=Delete

Generator commented 2 days ago

@Ofearghail i've explained that on the issue. The issue here is there's no warning that the files are being moved to .Trash instead of being deleted and the option isn't that "visible"

Tau-hub commented 2 days ago

Hello,

I don't know if it is related but I can't delete the content since 5.0.0. I am having "Bad descriptor" error when deleting. Deleting manually inside the docker works. Reverted to the previous version to make it work. Also using docker.

vivaldi_pJJkRvNlRb

The fix 'Under [BitTorrent], add this line: Session\TorrentContentRemoveOption=Delete' did not work.