qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.55k stars 3.91k forks source link

More color options in Costumize UI Theme #21526

Open Mncdk opened 6 days ago

Mncdk commented 6 days ago

Suggestion

Please add color options for the alternating colors used for the rows of torrents, instead of seemingly forcing the use of the windows accent color.

Use case

When using dark mode, I normally have teal chosen as the accent color (in windows, as a throwback to windows 2000), but when a random color is added to qbittorrents UI, which is already full of a lot of color coding for the various states of torrents, it can quickly become a visual mess.

If I could go into Costumize UI Theme and change these colors in the UI Theme Configuration dialog, qbittorrent would become useable again.

For now, I have to change up my system settings to accommodate one program forcing weird color decisions on me, which I don't think is ideal.

Extra info/examples/attachments

No response

xavier2k6 commented 5 days ago

instead of seemingly forcing the use of the windows accent color.

We rely on Qt's fusion style & Qt 6.5+ for the dark "app" mode (auto) support & in relation to the accent color being used for alternate rows etc.

xavier2k6 commented 5 days ago

When we read the dark system palette on Windows, then we use the theme's accent color for the QPalette::Highlight color role. This is however not quite correct, as the Accent is used in other places as well, and some controls use different colors (i.e. on Windows 11's "red" dark theme, the highlight is bright red, while the focus frames are in a paler orange). QPalette doesn't have an Accent color role right now, and adding that is a bit complex as the internal QPalette data structures need to change quite a bit once we go above 21 color roles - and we are at 21 already.

https://www.qt.io/blog/dark-mode-on-windows-11-with-qt-6.5#:~:text=When%20we%20read%20the%20dark%20system%20palette%20on%20Windows,%20then%20we%20use%20the%20theme's%20accent%20color%20for%20the%20QPalette::Highlight%20color%20role.