search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.48k stars 3.99k forks source link

WebUI: Hide context menu when clicking on a table row #21731

Closed PatrikElfstrom closed 2 weeks ago

PatrikElfstrom commented 3 weeks ago

This fixes a bug where the torrents table header menu could not be closed by clicking on a table row. This also fixes the same bug for other context menus.

Chocobo1 commented 2 weeks ago

@PatrikElfstrom Thank you!

Chocobo1 commented 1 week ago

@PatrikElfstrom This PR seems to bring regressions. For example, Download Rules in Rss Downloader cannot be selected. Could you take a look at it? I'm not sure what is the root cause, I only found it by bisect.

PatrikElfstrom commented 1 week ago

Yes! I can take a look in about 6 hours.

PatrikElfstrom commented 6 days ago

@PatrikElfstrom This PR seems to bring regressions. For example, Download Rules in Rss Downloader cannot be selected. Could you take a look at it? I'm not sure what is the root cause, I only found it by bisect.

Fixed in #21857

The reason for the bug is that there is a listener on the parent element #rulesTable which deselects the rules when clicking outside the dynamicTable. This pr allowed the click event to bubble up from the dynamicTable to the parent.