qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.33k stars 3.98k forks source link

STOP icon is grey instead of orange #21734

Open nokti opened 2 weeks ago

nokti commented 2 weeks ago

qBittorrent & operating system versions

qBit v5.0.1 lt 2.0.11 qt 6.7.3 Win 10 Pro x64 22H2 19045.5073

What is the problem?

The stop icon in the left side column is grey when it should be orange like on top I suppose.

image

Steps to reproduce

Launch qBit

Additional context

This happens whether dark mode is on or off (I disabled it through qt.conf).

Log(s) & preferences file(s)

qBittorrent.txt

stalkerok commented 1 week ago

Related discussion https://github.com/qbittorrent/qBittorrent/pull/20532#issuecomment-1995631296 @glassez @Chocobo1 @xavier2k6 @thalieht Anyone against making the icon orange?

ionGL commented 1 week ago

Just manually change the "stopped" icon with the orange one if you want. https://github.com/qbittorrent/qBittorrent/blob/master/src/icons/torrent-stop.svg

Or you can change the top "torrent-stop" icon to gray. https://github.com/qbittorrent/qBittorrent/blob/master/src/icons/stopped.svg

glassez commented 1 week ago

Or you can change the top "torrent-stop" icon to gray. https://github.com/qbittorrent/qBittorrent/blob/master/src/icons/stopped.svg

👎

nokti commented 1 week ago

Just manually change the "stopped" icon with the orange one if you want. https://github.com/qbittorrent/qBittorrent/blob/master/src/icons/torrent-stop.svg

I'd love to do that but where do I place this icon? There's no folder with the qBit icons.

stalkerok commented 1 week ago

2024-11-02_121151

glassez commented 1 week ago

Related discussion #20532 (comment) @glassez @Chocobo1 @xavier2k6 @thalieht Anyone against making the icon orange?

I don't care. The main thing is that it should not be gray in the toolbox and context menu, where it may look confusing (like a disabled/unavailable item).

xavier2k6 commented 1 week ago

Changing that icon to orange will then not match the corresponding text color in transfer list & there's already issues there......

stalkerok commented 1 week ago

I would change not only the icon, but also the text.

Pentaphon commented 1 week ago

I would change not only the icon, but also the text.

If you do this, you will get people complaining about their torrent list being full of orange text since a lot of people keep torrents in their stopped state.

The list should be mostly black text and the color should only change when something is happening to a torrent like:

red = error orange = stalled green = uploading data to peers blue = downloading data from peers

https://github.com/qbittorrent/qBittorrent/issues/21448 is my outline of how the text colors should be and I think many people agree with it.

sledgehammer999 commented 1 week ago

I propose treating the grey-icon as an intended differentiation. Aka non a bug.

Pentaphon commented 1 week ago

I propose treating the grey-icon as an intended differentiation. Aka non a bug.

I think the stop icon should be more recognizable as a stop icon, yet simple, like this.

3167008

stalkerok commented 1 week ago

Ok. Does anyone have any suggestions for a uniform color for the stop icon?

ArcticGems commented 1 week ago

I wonder if there is a good choice, even the creator of current icons said in hindsight that it would be best with 2 icon sets since it's hard to make it work for both light and dark mode.

Pentaphon commented 1 week ago

Ok. Does anyone have any suggestions for a uniform color for the stop icon?

If we want to keep it simple, it should be a simple red square or....a simple red octagon like so

oct

stalkerok commented 1 week ago

Red is reserved for critical errors, it's definitely not appropriate here.

Pentaphon commented 1 week ago

Red is reserved for critical errors, it's definitely not appropriate here.

How about a simple black circle with a white square inside it?

120632

nokti commented 1 week ago

LOL I just wanted my square to be orange, now I've got it and I'm happy. I'd rather the devs spent their time on more critical issues than this.

Pentaphon commented 1 week ago

LOL I just wanted my square to be orange, now I've got it and I'm happy. I'd rather the devs spent their time on more critical issues than this.

I'm fine with the orange square if the devs are ok with it. I just thought making the text orange as well was going too far.

nokti commented 1 week ago

I'm fine with the orange square if the devs are ok with it. I just thought making the text orange as well was going too far.

Text color should only change when a torrent is actively moving data or must be looked at.

I agree with you on that. I was half-joking anyway (although it's true that ressources are limited and should be focused on more important issues).

sledgehammer999 commented 1 week ago

I am inclined to close this as wontfix. Why? I just realized that in v5.0.x users can changed both colors and icons of the GUI. Just go to Tools->Options...->Behavior->Customize UI Theme... and theme the app any way you see fit for your tastes.

ionGL commented 1 week ago

I just realized that in v5.0.x users can changed both colors and icons of the GUI. Just go to Tools->Options...->Behavior->Customize UI Theme... and theme the app any way you see fit for your tastes.

The op didn't realize this either. When users have the option to change all icons and colors as they like, it's a waste of time to argue what the default ones should be at this point.

It would be nice if changing icons and colors would be applied on the fly, without reopening the program.

Pentaphon commented 1 week ago

Just go to Tools->Options...->Behavior->Customize UI Theme... and theme the app any way you see fit for your tastes.

I agree this is a solution, but we also do need to come up with better default colors and icons so we don't have so many people have to switch things around every time they install qBittorrent. We should still pursue a "2.0 version" of the light and dark themes.

stalkerok commented 1 week ago

@sledgehammer999 Why can't we make it a single color by default? Okay, gray isn't suitable. Why can't it be orange? I'm not suggesting this color particularly, but we can make the default icon (+text) a single color. And then users can change it to whatever they want.

sledgehammer999 commented 1 week ago

Why can't we make it a single color by default?

Do you mean same color for all states? Well, no. Traditionally we use different colors per state and switching to monochromatic would be a huge downgrade in UX.

stalkerok commented 1 week ago

Do you mean same color for all states?

For a stop state!

Pentaphon commented 1 week ago

Why can't we make it a single color by default? Okay, gray isn't suitable. Why can't it be orange? I'm not suggesting this color particularly, but we can make the default icon (+text) a single color. And then users can change it to whatever they want.

Nobody can agree on another color and people don't seem to like black/grey icons. We need to wait for somebody to fix all the icons on both dark and light themes so they all match well together and the community approves of it.