search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.48k stars 3.99k forks source link

Change the color of the stop status text and icon #21749

Open stalkerok opened 2 weeks ago

stalkerok commented 2 weeks ago

2024-11-02_220507 2024-11-02_220527

Closes https://github.com/qbittorrent/qBittorrent/issues/21734

Pentaphon commented 2 weeks ago

@stalkerok I have to disagree with the text being orange. A lot of people will complain because:

1) Orange is kind of a bright color that may indicate something is wrong, like red but medium urgency. I think orange text should mean a torrent is "stalled" like red text should indicate a torrent with an error. I outlined this in https://github.com/qbittorrent/qBittorrent/issues/21448 2) The people who stop their torrents will complain about seeing a sea of orange text like they currently complain about a sea of blue text. Stopped torrents should have black text with an orange icon. Active torrents should have the icon with up/down blue/green arrows.

Personally, I think you should follow what I outlined at https://github.com/qbittorrent/qBittorrent/issues/21448 as people seem to be responding well to it. We should also have a discussion with the community about having a larger default color change as you seem to be willing to make default color changes.

sledgehammer999 commented 2 weeks ago

I don't think we should change the color in the transfer list or the sidebar. Especially not to orange.

Pentaphon commented 2 weeks ago

I don't think we should change the color in the transfer list or the sidebar. Especially not to orange.

I am fine with the text color changing to orange when a torrent is stalled so a user can see it more easily when it stalls.

Ideally, we should have a better stop icon, but somebody needs to create one.

stalkerok commented 2 weeks ago

I don't think we should change the color in the transfer list or the sidebar. Especially not to orange.

Are there any pitfalls to using orange?