search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.47k stars 3.99k forks source link

Fixed tab stop order in the Options Dialog, Connection page #21856

Open maximmasiutin opened 6 days ago

maximmasiutin commented 6 days ago

The tab top order of "Global maximum number of upload slots:" and "Maximum number of upload slots per torrent:" was swapped. To reproduce the issue, focus "Global maximum number of upload slots" and press "Tab". Expected behavior: "Maximum number of upload slots per torrent:" should be focused. Actual behavior: focus jumps to other controls below. This pull request does not add or remove any lines, it just changes order of existing lines.

glassez commented 4 days ago

Doesn't seem to break anything although the tab stop order is already fixed in master

So what does this PR do then?

maximmasiutin commented 4 days ago

Doesn't seem to break anything although the tab stop order is already fixed in master

So what does this PR do then?

It puts the graphical controls in correct order. For example, they were 1, 3, 2, 0. Now they are 0, 1, 2, 3.

glassez commented 4 days ago

PR title says that it fixes tab stop order but @thalieht says that tab stop order is already correct. So I'm confused...

xavier2k6 commented 4 days ago

Any GUI changes should have screenshots......before & after.

maximmasiutin commented 4 days ago

These are not the GUI changes. The visible order of the controls is the same, it is only the tab order changes. I can make the screenshots but they are identical.