search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.1k stars 3.96k forks source link

Change copy .torrent files for finished to move .torrent files #2323

Open SpiralGalaxy opened 9 years ago

SpiralGalaxy commented 9 years ago

Can we please change the behavior of "Copy .torrent files for finished downloads to:" into move? I dont see the point of keeping both the original and a copy of a .torrent file once a torrent is done downloading. Move makes a lot more sense to me.

Thanks

Nerva72 commented 9 years ago

I was just about to request the same thing.

sle1306 commented 9 years ago

Yes it makes no sense to keep both files. Move instead of Copy (useless for me) would be greater, as µTorrent does. Can you please change that behavior ?

Thanks

txtsd commented 4 years ago

You guys are closing dupes for this but doing nothing to resolve it since 2014.

FranciscoPombal commented 4 years ago

You guys are closing dupes for this but doing nothing to resolve it since 2014.

Patches welcome!

txtsd commented 4 years ago

You guys are closing dupes for this but doing nothing to resolve it since 2014.

Patches welcome!

Point me to where it is in the code and I'll take a look!

thalieht commented 4 years ago

Point me to where it is in the code and I'll take a look!

https://github.com/qbittorrent/qBittorrent/blob/49e55d5a5d1b8440b56cb67a092b35ab09af3331/src/base/bittorrent/session.cpp#L2207

You'll be disappointed to know that it won't be a simple function call change from "copy" to "move". It copies from the internal \<hash>.torrent used by qBt to load torrents and not the original .torrent that users add new torrents from.

If i'm not mistaken, the only place qBt touches the original .torrent file for anything other than to read it, is when it is loaded from a watched folder to delete it after adding it.

thalieht commented 3 years ago

It just occurred to me that the options "Delete .torrents files afterwards" + "Copy .torrent files..." have the effect of what this issue asks for. And if you want the "Copy for finished downloads" option... well make sure you finish downloading the torrent.

clutchmaster420 commented 2 years ago

delete torrent afterwards only works for torrents that have been loaded not for completed torrents