qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.18k stars 3.9k forks source link

Option to add trackers to private torrents #4637

Open some-guy-23 opened 8 years ago

some-guy-23 commented 8 years ago

Right now there is an option to automatically add trackers to torrents. However, currently a check is performed and if the torrent is private, then the trackers will not be added.

Would be nice to have an option to override this check, and still add the additional trackers, even if torrent is private. I'd like to be able to cross-seed torrents between private trackers, which often carry the same releases.

Misiek304 commented 8 years ago

Isn't this against the rules and idea of a private torrent?

some-guy-23 commented 8 years ago

I don't believe so, why would it be? It is the equivalent of downloading .torrent files from two different private trackers, adding them to your client, and pointing them at the same file on disk.

Misiek304 commented 8 years ago

Yes, but isn't qBittorrent sharing peer list with other trackers and other peers regardless of the tracker they came from?

For example. You downloaded a torrent from tracker A. Then you added tracker B address to the same torrent. qBittorrent is downloading peer list from tracker A and B and sums them. Then a leech from tracker B wants to download the same torrent and connects to you. It downloads the whole peer list including the peers from tracker A.

I'm not sure if this is correct but if it is this makes a serious security issue because members of private trackers in most cases believe there are sharing files only with other members bind by the same rules. I understand that some private trackers have less restrained rules but still I don't believe implementing the feature you're requesting is a good idea. I guess it wasn't implemented in the first place because of those kind of issues.

some-guy-23 commented 8 years ago

I don't believe what you're describing it the default functionality. Maybe that is how it works when you setup qBittorrent as a tracker itself though? Even then, users from both trackers would have to add you as a tracker on top of that.

Otherwise, what server would be facilitating the handshake between peers on TrackerA and those on TrackerB? If you could just "introduce" any peers, untracked, into a swarm on private tracker then you'd basically be able to give free leech benefits to anyone with just their IP.

For peers to connect to other peers on a tracker, they have to announce via that tracker, not via a 'man in the middle' as it were. That is my assumption at least. Does that make sense?

swannie-eire commented 3 years ago

+1 for me.

I was trying to add a torrent from a PT using the webUI and never got a error or anything. After numerous attempts and not seeing the torrent added I opened it with a text editor and could see the torrent hash was the same as another torrent from another PT. I then discovered that if the torrent is private trackers are not added to it.

It is incredibly labours process to add the torrent trackers manually as

On many private torrent sites the same torrent is uploaded to them just with different trackers as in many cases it is bots that upload them or the sites are owned by the same people. Having to manually add all the trackers for these sites is obvs not ideal when other torrent clients like transmission allow this and the trackers will be added if the torrent is not private.

At least there should be a warning that the torrent could not be added as private one already exists.

thalieht commented 2 years ago

@summerqB is this a valid request?

ghost commented 2 years ago

This is an invalid request. Most well known pvt trackers will randomize their info-hash by adding some entropy to the info-hash dict. This way the hashes of two private trackers usually never match and users are able to cross seed the same torrent without merging stats on multiple trackers. This responsibility rests on the private tracker to ensure their torrent hashes remain unique so users may cross seed. Adding multiple private trackers to same torrent is not considered acceptable by private trackers due to stats merging.

swannie-eire commented 2 years ago

This is an invalid request. Most well known pvt trackers will randomize their info-hash by adding some entropy to the info-hash dict. This way the hashes of two private trackers usually never match and users are able to cross seed the same torrent without merging stats on multiple trackers. This responsibility rests on the private tracker to ensure their torrent hashes remain unique so users may cross seed. Adding multiple private trackers to same torrent is not considered acceptable by private trackers due to stats merging.

Many PT have sister sites and those usually have the same infohash so same torrent. IPT and TD for example.

Also if ye don't implement the adding of a tracker to an existing torrent then qbit should at least produce an error along the lines of "unable to add torrent as it already exists" or something like that as I spent a long time trying to add a torrent that already was in qbit. All I kept getting was torrent successfully added.

Transmission for example if a torrent already is in transmission and you try to add it again with different trackers it will prompt you to add the trackers from the new torrent to the one already in transmission.

I for one am seeding numerous torrents that have unique infohashes across multiple sites and I have to go through each one to find the one that matches the infohash of the one I am trying to add to add the tracker to it.

ghost commented 2 years ago

Also if ye don't implement the adding of a tracker to an existing torrent then qbit should at least produce an error along the lines of "unable to add torrent as it already exists" or something like that as I spent a long time trying to add a torrent that already was in qbit. All I kept getting was torrent successfully added.

qBt does inform the user about duplicate torrent and inability to merge trackers if they’re set as private.

Transmission for example if a torrent already is in transmission and you try to add it again with different trackers it will prompt you to add the trackers from the new torrent to the one already in transmission.

Current qBt auto merges trackers on public torrents but this behaviour is changed in upcoming 4.5.0 release where it’ll prompt to merge them on public torrents. However this option will not be made available for private torrents due to aforementioned reason.

ghost commented 2 years ago

I for one am seeding numerous torrents that have unique infohashes across multiple sites and I have to go through each one to find the one that matches the infohash of the one I am trying to add to add the tracker to it.

I don’t understand how qbt could help that situation. It’s the private tracker’s choice to create unique info hashes to prevent cheating.

swannie-eire commented 2 years ago

Also if ye don't implement the adding of a tracker to an existing torrent then qbit should at least produce an error along the lines of "unable to add torrent as it already exists" or something like that as I spent a long time trying to add a torrent that already was in qbit. All I kept getting was torrent successfully added.

qBt does inform the user about duplicate torrent and inability to merge trackers if they’re set as private.

What version is this in as I don't get it in 4.3.9?

I for one am seeding numerous torrents that have unique infohashes across multiple sites and I have to go through each one to find the one that matches the infohash of the one I am trying to add to add the tracker to it.

I don’t understand how qbt could help that situation. It’s the private tracker’s choice to create unique info hashes to prevent cheating.

I wouldn't have to find the existing torrent that matches the inof hash if it asked me to add it and if it allowed me to add to the existing torrent. you could just filter for that torrent and then filter for the tracker that you downloaded the torrent from. This would allow you to find the torrent with the matching info hash very quickly instead of going through each torrent to find the one with the same info hash.

WrayOfSunshine commented 1 year ago

Most private trackers will ban you for this.

elboletaire commented 11 months ago

Most private trackers will ban you for this.

Absolutely. I'm on more than 10 private trackers, and not a single one allows you to add new trackers to downloaded torrents. You can do cross-seed tho, which is basically re-add the same torrent from another tracker (and have it twice in the client, but each one with different trackers).

btw I ended up here because the qbittorrent interface isn't clear enough about these trackers added. The UI made me think it was gonna add the trackers for every single download, not only the public ones. Maybe the text should say "public downloads" instead of just "downloads" as it does right now.