Make "Country" column independent from "Flag"

[ghost]

Before suggesting, I might have to ask if this is possible?

Before qBittorrent v3.3.4 I was used to the empty column, under which the flags would appear. I could resize it withough having any problems for the next starts of qBittorrent. With v3.3.4, the empty column got renamed to "Country" (which is understandable under the fact that you can choose the shown columns now). Resizing it to the minimun, so just the little flag is shown is okay for the session, but after the next start of qBittorrent, one has to do it again.

Though having limited image editing skills, I tried to create an example of how my idea would look like. [For the screenshot I used the most recent alpha version from the forums, with Windows 7 64bit Home Premium 64Bit. Libtorrent version ect. is visible in the forums, of course).

One thing to think about though is that this column might be confusing with the "Flags" column.

Not to compare but to mention might be that I have seen this column in Vuze (or back-then Azureus). If it is possible with libtorrent combined with qBittorrent, I'd be super duper happy for suggesting it. :smile:

[ghost]

@LordNyriox My initial thought actually was to seperate those two columns because of the basic thinking country =/= flag tbh. And as I described, I'm a little annoyed by resizing the column over and over again. :sweat_smile: I surely would be one of those persons to disable the Country resolution, too, if my screen is too small (which shouldn't be the case on my Desktop, but on my Laptop - depening on the space that is left).

Besides, I had two cases for countries not getting resolved (one peer was in Zimbabwe and one in Moldova iirc). I have no idea why that happened, but both peers appeared without any flag, but the hostname was resolved including the country's ccTLD. Could this be some kind of error in the GeoLite Database? (if so, the version used back then was from April 14, if I'm not mistaken).

[thalieht]

First of all i'd like to say that this is trivial to make Combined: Seperate: Or we could add an option in advanced to choose between flag+tooltip or Combined or Seperate... jk that would be bloat :P

With Combined we'd have a tiny problem with vertical alignment of text with Switzerland and Nepal as their icons are 11x11 and 9x11 respectively instead of 16x11 like all the others.

I could make a PR with it but i don't wanna waste my time considering that i suggested the same thing some time ago and it was rejected #3408.. hope you'll have better luck.

And secondly @netswap do you know you can get a tooltip with the country name if you hover over a flag?

As for resizing the country column i'll make a PR soon that should fix it.

[Chocobo1]

As for resizing the country column i'll make a PR soon that should fix it.

I'm thinking qbt should save (every) columns width on exit & restore it on launch.

[ghost]

And secondly @netswap do you know you can get a tooltip with the country name if you hover over a flag?

Bruh, I'm definitely not a first-time user. Of course I know about this feature. :smile: Again, it is just an idea, and any input is welcome! Yet, I did not do that much researching, to find your suggestion. So even if I should fail, I'm totally fine with it. As for the columns width, qBittorrent does save it, but because the column is wider than the flags shown there due to the length of the word "Country", it is wider than I want it to be. My perfect width would let "Cou" show instead of the full word. tl;dr: It's getting resetted because of the word's (Country) length.

[thalieht]

@Chocobo1 AFAIK it reset them only if the client was restarted while they were hidden and unless i broke something else, it's fixed in my PR. @netswap hehe ok :) i just looked in your posts for something that could denote that you know about it but i didn't find and i just said it. As for country column it's width is specifically reset on every restart and you are right that wasn't a problem when it had no name. With my PR it's width is gonna get saved and it will get reset if/when there is actually a problem.

[ngosang]

I agree with add a new column so we have Flag and Country columns.

[Gittyperson]

Is there an update on this? Thanks.

[ghost]

I am closing this down until futher notice, as I doubt that this feature is going to happen.

[thalieht]

Dooooon't close it! The more issues with this, the bigger the chance it'll be accepted.

[GitToLife]

I'm second to the idea making one more column for country's name.

[jeremy-wendelken]

Please add this! This would be so awesome and an interesting way to learn country flags! <3