qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
26.1k stars 3.84k forks source link

"Require encryption" + "Download in sequential order" breaks "Download first and last pieces first" feature #5692

Closed briankendall closed 5 years ago

briankendall commented 7 years ago

As the title says, if the user has their encryption mode set to "Require encryption" in Options / BitTorrent and downloads a torrent with both "Download in sequential order" and "Download first and last pieces first" enabled, the "Download first and last pieces first" feature breaks, and the first and last pieces are downloaded last instead of first. See this screen shot:

screen shot 2016-08-31 at 4 13 10 pm

Took me and a friend of mine several hours to track down this one! Reproduced in 3.3.6 on several OS X systems. Have not tried to reproduce in Windows or Linux.

thalieht commented 7 years ago

I can reproduce in win 7 with official 3.3.6 and 3.3.7 but i can't reproduce in linux with libtorrent 1.1.1 compiled from current master (practically identical to 3.3.7).

I skimmed through libtorrent's changelog and it mentions some stuff about encryption in 1.1.0. * separate crypto library configuration and whether to support bittorrent protocol encryption * simplify bittorrent protocol encryption by just using internal RC4 implementation. * deprecate separate settings for peer protocol encryption

I guess we'll have to wait for libtorrent 1.1.x if that's the reason.

thalieht commented 7 years ago

I tested it with this Win qbt snapshot https://qbforums.shiki.hu/index.php/topic,4113.0.html with libtorrent 1.1 and couldn't reproduce, so the problem is fixed in 1.1 or 1.1 changed some options and qbit doesn't actually use Require encryption.

ssjkakaroto commented 7 years ago

This issue is still present on 3.3.10. An unreliable workaround is to enable only "Download in sequential order", wait until the first piece is downloaded and then enable "Download first and last pieces first".

ngosang commented 5 years ago

We are closing all issues related to old qBittorrent versions (qBittorrent < 4.1.0). Please, update to last release and, if the bug/error/crash is still present, open another issue. Thank you.