search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.05k stars 3.96k forks source link

No error raised when a ipfilter file is provided but the path is wrong #7143

Open ccleaud opened 7 years ago

ccleaud commented 7 years ago

Please provide the following information

qBittorrent version and Operating System:

qBitTorrent 3.3.14 running on Windows 7 x64 (6.1.760x)

If on linux, libtorrent and Qt version:

N/A

What is the problem:

When an invalid ipfilter file name is provided, qBitTorrent shows an informational message instead of an error (or warning) message.

Successfully parsed the provided IP filter: 0 rules were applied.

What is the expected behavior:

An error (or warning) message like "No IP filter rule applied because IP filter file couldn't be read: ${the-provided-file-name}"

Steps to reproduce:

  1. Start qBitTorrent
  2. Go to Tools --> Options --> Connection --> IP Filtering
  3. Enter a valid file name
  4. Click OK
  5. Stop qBitTorrent
  6. Remove the file referenced at step 3
  7. Start qBitTorrent
  8. Look at execution logs

Extra info(if any):

Thanks for fixing :)

qriff commented 5 years ago

Additionally:

What is the problem:

When using the filename ~/biglist.p2p (file exists) the result is: Successfully parsed the provided IP filter: 0 rules were applied.

However when referring to the complete path /home/sameuser/biglist.p2p the result is: Successfully parsed the provided IP filter: 520667 rules were applied.

What is the expected behavior: Tilde expansion or at least \<File not found> or \<illegal characters / path>

Extra info: Open since Jul 22, 2017

ghost commented 2 years ago

Bug is still present in 4.4.3.1.