search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.07k stars 3.96k forks source link

Sequential/first&last hidden when selecting multiple torrents #7509

Closed m-sundman closed 2 years ago

m-sundman commented 7 years ago

qBittorrent version and Operating System:

qbittorrent: 3.3.16-0ppa1~zesty Ubuntu Linux 17.04

If on linux, libtorrent and Qt version:

libtorrent-rasterbar9: 1.1.5+git20170709.1280361236-1ppa1~zesty1 libqt5core5a: 5.7.1+dfsg-2ubuntu4~1.17.04.1

What is the problem:

If I select 2 torrents the right-click menu shows the "Download in sequential order" and "Download first and last pieces first" options only if they have the same value in both torrents.

What is the expected behavior:

The options should always be shown, as a tri-state checkbox like in all other programs and quidelines on the planet. Assuming a QCheckBox is used the value in the case of mixed values should be Qt::PartiallyChecked: http://doc.qt.io/qt-5/qt.html#CheckState-enum

Steps to reproduce:

  1. Start 2 torrents.
  2. Set "Download in sequential order" and "Download first and last pieces first" on one of them.
  3. Select both of them.
  4. The "Download in sequential order" and "Download first and last pieces first" options are now hidden from the right-click menu.
m-sundman commented 6 years ago

Still an issue in qbittorrent 4.1.1.99~201805272202-6377-ea5a290~ubuntu18.04.1

thalieht commented 2 years ago

Now they aren't hidden.