Create Subfolder should actually create a subfolder for single file torrents

mzso commented 6 years ago

qBittorrent version and Operating System:

All

What is the problem:

You can only create a sub folder for single file torrents which don't have one, by manipulating the download path, which has issues. Particularly it spams the MRU list.

What is the expected behavior:

QB could load these with the "create subfolder" unchecked and create one automatically when the option is checked, using the filename without the extension.
OR the subfolder might be created automatically and the user will need to uncheck it if it's undesired.
In probably both cases a sub-option for "create subfolder for torrents with multiple files" is needed, to cater for different people. eg: create subfolders for single file torrent too.
Maybe the simplest would be to just replace the "create subfolder for torrents with multiple files" setting with one where the user could choose select to all/only-multi-file/none for torrents to have a sub-folder. And just have a three state checkbox (with a helpful tooltip) or something similar on the add torrent window that corresponds to this.

Extra info(if any):

By the way, currently the behavior is contradictory to the UI. Because the "create subfolder" option in the add torrent window appears for single file torrents too (checked by default) and it does nothing, it's non-functional in this case.

slrslr commented 6 years ago

I think this is similar feature request: https://github.com/qbittorrent/qBittorrent/issues/7655 And i would also like to have this feature (creating subfolder even for one file torrents).

refriedfood commented 6 years ago

Not keeping the original directory and file structure of an upload is a file management nightmare. It should if you receive

John (dir) -- \Jon\file(s)

By default your dl should never only be the files, but it should include the John (dir) intact and its files inside it. Why does this split by default if it's only 1 file? It's awful and ruins any scene release.

wernerml commented 6 years ago

+1

Rouzax commented 5 years ago

I would also like the ability for single files to be placed in a subfolder. As of now (v4.1.3) it only works for multi files torrents.

kulmegil commented 5 years ago

+1 THIS really ruins the "Automatic Torrent Managment" idea

ChaoSong817 commented 4 years ago

+1 Appreciate it if add this option in settings!

j1warren commented 4 years ago

I like the current way, so if implemented there should be an option to preserve current behavior

mzso commented 4 years ago

@j1warren commented on 2019. nov. 25. 09:29 CET:

I like the current way, so if implemented there should be an option to preserve current behavior

I already added some ideas about that when I opened the issue. Added a bit more to it.

refriedfood commented 4 years ago

I like the current way, so if implemented there should be an option to preserve current behavior

Of course, I don't see why anything should not be an optional setting unless the opposite breaks something.

ChaoSong817 commented 4 years ago

I like the current way, so if implemented there should be an option to preserve current behavior

Of course, I don't see why anything should not be an optional setting unless the opposite breaks something.

Could qbittorrent copy .torrent file to the downloaded file subfolder as well? .torrent file take very minor space. I manually copy torrent file from BTbackup folder is very inconvenient. Because their name are in HASH, I have to check every file. But those do not like this can very easily delete it form downloaded subfolder.

ChaoSong817 commented 4 years ago

Or Can I use some syntax in "copy .torrent file to:" to represent my subfolder to automatically copy it there?

mzso commented 4 years ago

@Ch-Song This is not relevant to the issue. But there are two options (one is for finished torrents only) that you can use to copy torrent files in a specific folder. They have normal names there.

I don't think a copy to download folder will ever materialize, but you can open an issue for it.

refriedfood commented 4 years ago

I like the current way, so if implemented there should be an option to preserve current behavior

Of course, I don't see why anything should not be an optional setting unless the opposite breaks something.

Could qbittorrent copy .torrent file to the downloaded file subfolder as well? .torrent file take very minor space. I manually copy torrent file from BTbackup folder is very inconvenient. Because their name are in HASH, I have to check every file. But those do not like this can very easily delete it form downloaded subfolder.

You can do this for a separate directory already, however, having go into the same directory as the new download is completely different. There is an option as of now that allows you to make a copy of the torrent file to a new directory. That is the back up copy. You'd still have the hash version and the copied version, and the latter retains its original name.

hukasu commented 4 years ago

Could change the "When adding a torrent" -> "Create subfolder for torrents with multiple files" to be a dropdown instead of a checkbox with "Never", "Torrent with multiple files", and "All torrents"

mcfalld commented 3 years ago

Really need this to have a functional way to auto manage torrents

Dorumin commented 3 years ago

I've noticed that the checkbox for this setting has now been renamed to "Keep top-level folder", however I'm pretty sure this doesn't change behavior. It's still the same "if it's a single file, you won't get a folder", just more ambiguously named

Got here because I've been yearning for my torrent download folders to be homogeneous, it's a nightmare to have a 50/50 file/folder split, so I would definitely like having the option to have folders always be created for torrents

Rouzax commented 3 years ago

In the end I just worked around it with my post processing script.

thalieht commented 3 years ago

This is implemented.

Dorumin commented 3 years ago

It appears this was fixed in the PR #13955, thank you @glassez!