qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.06k stars 3.89k forks source link

Remove automatic mode and just update the download path on category selection #7789

Open mzso opened 6 years ago

mzso commented 6 years ago

qBittorrent version and Operating System

4.0.0 Win8.1

What is the problem

So basically the way I see it what automatic mode only does is disable the save path. So why have it at all? It's just confusing. Also, if I'm in manual mode why changing the category does not change the path, which doesn't make sense. Why not? Furthermore the dropdown to change mode is counterintuitive. there are only two modes. Why not just have button to change (or radio buttons, or whichever that shows both without having to bring up a menu pointlessly)

What is the expected behavior

Changing the category should just load the save path associated and let the user customize it if he desires.

Extra info(if any)

I for one find all the option related to this confusing and difficult to understand, with the relocate/switch-to-manual-mode options. All this seems needlessly complicated and mostly redundant.

What does manual mode even do when a torrent is already added? I can't see anything different in the context menu. This whole manual/automatic stuff seems pretty murky and intuitive to me.

thalieht commented 6 years ago

I haven't given this much thought (to judge if you're right) but maybe you are. When categories were designed there were no tags and manual mode served as a tag AFAIK.

glassez commented 6 years ago

Manual mode User manually control torrent save path. Categories are only for some structuring.

Automatic mode Torrent save path are controlled by category associated with torrent.

@glassez: You designed the Automatic Management system. Thoughts?

I designed this subsystem as a systematization of an existing "labeling" subsystem whose behavior was inconsistent. Personally I don't use it. But there were a lot of suggestions to expand it to control more torrent options through the categories.

What is the actual usage scenario that is not covered by the current implementation?

mzso commented 6 years ago

@glassez I'm not sure automatic mode serves a meaningful purpose anymore. You can just update the download path when a category is selected besides assigning the the torrent to a category. Does it bring anything extra?

glassez commented 6 years ago

You can just update the download path when a category is selected besides assigning the the torrent to a category.

This sentence is unclear for me. What do you mean exactly?

I'm not sure automatic mode serves a meaningful purpose anymore.

I don't intend to drop out "auto mode" just because someone alone thinks it meaningless. If it meaningless for you don't use it. But if you're missing something in the current implementation, I'll repeat my question:

What is the actual usage scenario that is not covered by the current implementation?

mzso commented 6 years ago

@glassez commented on 2018. júl. 31. 20:51 CEST:

You can just update the download path when a category is selected besides assigning the the torrent to a category.

This sentence is unclear for me. What do you mean exactly?

Well, if QB'd change the download path in what is now manual mode, when you select a category it'd essentially accomplish what automatic mode does without the need for a separate mode.

I'm not sure automatic mode serves a meaningful purpose anymore.

I don't intend to drop out "auto mode" just because someone alone thinks it meaningless. If it meaningless for you don't use it.

But if you're missing something in the current implementation, I'll repeat my question:

What is the actual usage scenario that is not covered by the current implementation?

Alright. There's the two other things I mentioned in the OP then in relation to categories/modes.

glassez commented 6 years ago

Well, if QB'd change the download path in what is now manual mode, when you select a category it'd essentially accomplish what automatic mode does without the need for a separate mode.

What about those users who don't want qBt to change the download path when you select a category? Or maybe you don't like the term "automatic" exactly? Well, it is quite appropriate, since it is applied to the action that the program performs on its own at some event, depending on the preliminary settings, i.e. automatically.

Alright. There's the two other things I mentioned in the OP then in relation to categories/modes.

It's too verbose, and there's too much emotion. I don't understand English so well to dig into that pile of words trying to fish for something useful. Could you describe your problems more formally? For example, in the form (for each problem):

  1. what I'm doing,
  2. what I expect to get as a result,
  3. what I really get and why is it wrong.

And please try to use more precise (unambiguous) terms. E.g. what you mean in "Changing the category should just load the save path associated"?

glassez commented 6 years ago

The feature (manual + automatic modes) was conceived to cover a variety of use cases. Perhaps some case was missed. Or feature isn't enough convenient and clearly configurable... So I ask you to describe your use case.

mzso commented 6 years ago

@glassez commented on 2018. aug. 1. 06:17 CEST:

It's too verbose,

glassez commented 6 years ago

In that case, what you want has nothing to do with "Automatic mode". All you need is having ability to use category save path as a template for torrent save path in "Add new torrent" dialog (when Manual mode is used). You should have made this as a "wishlist" issue initially, instead of scolding functions that you don't use (and don't even know what they're useful for). Believe me, this behavior does not help you to solve your problem.

mzso commented 2 years ago

@glassez commented on 2018. aug. 13. 14:23 CEST:

You should have made this as a "wishlist" issue initially, instead of scolding functions that you don't use (and don't even know what they're useful for). Believe me, this behavior does not help you to solve your problem.

I was merely suggesting a simplification of the UI. Because it seemed to me it was needlessly complicated and a tad confusing.