search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.75k stars 3.92k forks source link

Qbittorrent 4.1.1 reports double download size to private tracker #9147

Closed zinemaniac closed 6 years ago

zinemaniac commented 6 years ago

Please provide the following information

qBittorrent version and Operating System

Qbittorrent 4.1.1 on Windows 7

What is the problem

Qbittorrent 4.1.1 reports double download size to private tracker(TL) while showing correct in client. ratio_error

zinemaniac commented 6 years ago

And i discovered that it's not double. It can be anything. Sometimes it's correct(unusual), mostly totally messed up. qbittorrent_ratio_fail

thalieht commented 6 years ago

Fixed in libtorrent 1.1.8 and it will be in qBt 4.1.2.

FranciscoPombal commented 6 years ago

@thalieht can you please link the relevant PR/discussion?

thalieht commented 6 years ago

https://github.com/arvidn/libtorrent/pull/3025 Supposedly it should be in 4.1.1 since sledgehammer usually uses the latest commit from RC_1_1 but according to this changelog entry https://github.com/arvidn/libtorrent/commit/4cef1814b074c215b21d1cea6051c6e971552280#diff-02f0b547c2779d25cff89672135f20e3 it was moved in 1.1.8 and considering this issue.. i guess it didn't make it to qBt 4.1.1.

greenbench commented 6 years ago

As for https://github.com/arvidn/libtorrent/pull/3025 it did make it to qB 4.1.1. But I guess this is something different.

thalieht commented 6 years ago

If you are sure it did make it to 4.1.1 we should call arvidn.

zinemaniac commented 6 years ago

It happened to a file downloaded 2 days ago with 4.1.1.

zinemaniac commented 6 years ago

Hopefully this fixes it. Now i'm just waiting for a new version of QbitTorrent with this libtorrent in it. libtorrent_buggy

ivan commented 6 years ago

@zinemaniac you're looking at the fix https://github.com/arvidn/libtorrent/commit/243353a14482b37dc84bd1abfff40049f5d18b18 which is a parent of https://github.com/arvidn/libtorrent/commit/6ec6c1b34055c226f7f869cf213a995a574c1606, which was the libtorrent commit used in the official qBittorrent 4.1.1 builds ("1.1.7+git6ec6c1b340"). If you're sure you saw this with a download started in 4.1.1, you might be seeing a different bug.

zinemaniac commented 6 years ago

This bug also appear when I use Deluge.