qblindeman / eid-mw

Automatically exported from code.google.com/p/eid-mw
GNU Lesser General Public License v3.0
0 stars 0 forks source link

Compatibility issue with Belpic application: missing functionality "belpic_set_language" (beidlibopensc.dll) #73

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. the application calls the function "belpic_set_language" in 
beidlibopensc.dll for a particular pinpad reader (the citizen reader)

2. the application places a signature on this pinpad reader (using PKCS11 and 
the old pinpad library convention for Belpic certified card readers with pinpad)

What is the expected output? What do you see instead?

Expected: UI on the screen and on the reader display in the desired language.

Actual: the default language is used.

What version of the product are you using? On what operating system?

Windows XP SP3, latest middleware 3.5.6 build 6968

Please provide any additional information below.

The next release of the Belpic application (CR102, 10 years validity of eID 
cards) will have to use the "official" Fedict middleware. The old (Zetes) 
middleware provided a function "belpic_set_language" in beidlibopensc.dll. 
Apparently the beidlibopensc.dll is still installed for compatibility reasons, 
but it looks like it is no longer used, and no alternative functionality for 
"belpic_set_language" has been provided.

Impact: blocking issue for Belpic change request CR102.

Original issue reported on code.google.com by Danny.He...@gmail.com on 18 Aug 2011 at 9:18

GoogleCodeExporter commented 9 years ago
Some additional info:

The old functionality was implemented in 
"_src\beid-2.6\src\newpkcs11\src\libopensc\card-belpic.c"

lines 578 ... 625

Reason for implementing the functionalityu (lines 77-80):

 * About the belpic_set_language: the RA-PC software (including the pkcs11 lib)
 * in the Brussels' communities should be able to change the language of the GUI
 * messages. So the language set by this function takes priority on all other
 * language-selection  functionality.

Original comment by Danny.He...@gmail.com on 18 Aug 2011 at 12:05

GoogleCodeExporter commented 9 years ago
Hi Danny,

Sorry for the late reply, I've been on holidays.
I'll have a look at this.

Original comment by frederik...@gmail.com on 6 Sep 2011 at 6:41

GoogleCodeExporter commented 9 years ago
Hi Danny,

The language used by the software that communicates with the old pinpad library 
(see \cardlayer\old\PinpadLibOldBeid.cpp), should be the one it finds in the 
registry under: 
HKEY_CURRENT_USER\Software\BEID\general\language or if not there in :
HKEY_LOCAL_MACHINE\Software\BEID\general\language
if no valid language could be found, it uses the default (en)

e.g our eidviewer can be used to set the language, or you could do it by means 
of the beidcommon.dll: 
eIDMW::BEID_Config config(eIDMW::BEID_PARAM_GENERAL_LANGUAGE);
        config.setString("en");

However, this language is only checked during loading of the pinpad lib, and 
you probably want to able to change the language at all times?

I'll check with the team if we want to check which language to use more often, 
or allow language setting through the API

Wkr,
 Frederik

Original comment by frederik...@gmail.com on 6 Sep 2011 at 12:01

GoogleCodeExporter commented 9 years ago
I created a new build : 
http://code.google.com/p/eid-mw/downloads/detail?name=eID-QuickInstaller-build-6
995.exe&can=2&q=

When using the old pinpadlib plugins, the language is now checked each time 
before a PIN operation.
Tested on a Win XP SP 3 with ETS reader, and using the eidviewer to change the 
language.

Original comment by frederik...@gmail.com on 9 Sep 2011 at 9:50

GoogleCodeExporter commented 9 years ago
Thanks Frederik, I've been on holiday myself.

I'll download the new version and test it. I suppose I will directly 
manuipulate the registry key under HKEY_CURRENT_USER.

Thanks again!

Danny

Original comment by Danny.He...@gmail.com on 19 Sep 2011 at 9:51

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Works a treat!

Had to think a bit because the old API allowed to change the language of each 
reader seperately, but it took just a few lines of code to get it working 
exactly like it did with the old Zetes PKCS11.

Kind regards

Danny

Original comment by Danny.He...@gmail.com on 20 Sep 2011 at 6:20

GoogleCodeExporter commented 9 years ago
Excellent,

Thank you for the feedback.

With Kind Regards,
 Frederik

Original comment by frederik...@gmail.com on 20 Sep 2011 at 7:25