Addition of room owners and banning functionality

qbreader / website

A text-based quizbowl packet reader with support for both single- and multi-player.

https://www.qbreader.org

MIT License

39 stars 20 forks source link

Addition of room owners and banning functionality #321

Closed 1337isnot1337 closed 3 weeks ago

1337isnot1337 commented 1 month ago

This is the PR for the room owners/banning mechanisms. Feel free to look over the changes and ask me any questions, organize it the way you prefer, or just change around the code. Linted with semistandard.

Additions:

Creator of a room is given Owner metadata
Creator has a crown emoji next to their name to set them apart
Creator sees a ban button next to each name, pressing it will permaban said player from that room in particular
This does not apply for the default rooms

Future goals:

[x] Only have creators in private rooms
[x] Add a votekick feature to public rooms and the default rooms where a majority of players can remove another
[x] Smooth out the code
[x] Add a way to mute someone's chat

1337isnot1337 commented 1 month ago

With new commits a VK button is added next to each player's name, similar to ban button. When pressing VK a 90 second cooldown activates for that user to init a VK. the VK init is announced to players, along with the total threshold. If a different player then presses the VK button for that person who the VK was initiated on, they will have voted (also cooldown). Once enough votes have occurred to meet the threshold the user is banned and cannot rejoin the room.

In private rooms, the owner cannot be votekicked
In public rooms, the owner is not marked and can not ban, but if room is switched to private then owner is marked + can ban

I'm sure there's some loophole here I'm missing, lol.

1337isnot1337 commented 4 weeks ago

Finished all changes. Ready for final review/PR approval

geoffrey-wu commented 3 weeks ago

PR looks good, but I would like to test it across multiple clients and also add a description of votekicks somewhere on the page

1337isnot1337 commented 3 weeks ago

PR looks good, but I would like to test it across multiple clients and also add a description of votekicks somewhere on the page

That is a good idea, I do not know how this would perform on other platforms although it should work regardless. For the votekicks, I think adding a paragraph on the about page would be best. Can't think of anywhere else to put it.

Edit: added the about page changes