erikarn
commented
11 years ago Hm! Now I'm going to have to go digging through the WMI "spec" (or what counts as it)
- We should pad that to be a DWORD multiple in size, no?
- Fields should be DWORDs, or they won't be "fixed" right when on different endian machines?
- .. hm, I should look at whether ath9k_htc is doing endian swapping, or whether it's done in the firmware.
- Also, should we include a 32 or 64 byte git version id? I wonder what the limit is for WMI notifications.
Good work though! I'd like to see the addition of new WMI commands. We just have to now go through the pain of figuring out how it's supposed to happen!
adrian
On 17 April 2013 05:51, KrasnikovEugene notifications@github.com wrote:
New command WMI_GET_BUILD_NUMBER has following fields: major minor tag
Signed-off-by: Eugene Krasnikov k.eugene.e@gmail.com
You can merge this Pull Request by running
git pull https://github.com/KrasnikovEugene/open-ath9k-htc-firmware get_build_number
Or view, comment on, or merge it at:
https://github.com/qca/open-ath9k-htc-firmware/pull/18
Commit Summary
Add WMI_GET_BUILD_NUMBER
File Changes
M target_firmware/wlan/if_ath.c (14) M target_firmware/wlan/include/k2/wlan_cfg.h (5) M target_firmware/wlan/include/magpie/wlan_cfg.h (3) M target_firmware/wlan/include/wlan_hdr.h (6) M target_firmware/wlan/include/wmi.h (1)
Patch Links:
https://github.com/qca/open-ath9k-htc-firmware/pull/18.patch https://github.com/qca/open-ath9k-htc-firmware/pull/18.diff
KrasnikovEugene
New command WMI_GET_BUILD_NUMBER has following fields: major minor tag
Signed-off-by: Eugene Krasnikov k.eugene.e@gmail.com