search

qca / open-ath9k-htc-firmware

The firmware for QCA AR7010/AR9271 802.11n USB NICs
Other
429 stars 182 forks source link

Io clean 2014.04.29 #56

Closed olerem closed 8 years ago

olerem commented 10 years ago

This patch set makes sure we use one way to to access registers. It will also make debug easier, since we PC will point to actual code and not hidden by ioread/iowrite function.

erikarn commented 10 years ago

There's some conflicts; I'll have to deal with those.

The reason for all the macros is that this code originated from the BSD driver source that Atheros used internally. I prefer OS_REG_READ() and OS_REG_WRITE() because it lets one insert other bits and pieces into the macro if required (eg register access tracing.) It also lets you do things like do flushes after writes if your platform supports it. But, this is firmware and we can always go through and undo it afterwards if we need to.

olerem commented 10 years ago

Ah... :) i used linux version of iowrite and ioread as example.

erikarn commented 10 years ago

They'll end up being macros anyway. :P

-a

On 23 May 2014 09:17, Oleksij Rempel notifications@github.com wrote:

Ah... :) i used linux version of iowrite and ioread as example.

— Reply to this email directly or view it on GitHubhttps://github.com/qca/open-ath9k-htc-firmware/pull/56#issuecomment-44031267 .

olerem commented 10 years ago

yep

olerem commented 10 years ago

I see the reason of conflict. I can fix it now. Should i?

erikarn commented 10 years ago

yup

On 23 May 2014 09:24, Oleksij Rempel notifications@github.com wrote:

I see the reason of conflict. I can fix it now. Should i?

— Reply to this email directly or view it on GitHubhttps://github.com/qca/open-ath9k-htc-firmware/pull/56#issuecomment-44032005 .