Wrong setting of txstatus flags (patch).

[iazz]

The flags in WMI_TXSTATUS_EVENT structures are not reset properly, while the memory is reused every time. Please consider applying the following patch:

--- a/target_firmware/wlan/if_owl.c
+++ b/target_firmware/wlan/if_owl.c
@@ -556,6 +556,8 @@ void ath_tx_status_update(struct ath_softc_tgt *sc, struct ath_tx_buf *bf)
    if (txs == NULL)
        return;

+   txs->txstatus[txs->cnt].ts_flags = 0;
+
    txs->txstatus[txs->cnt].cookie = bf->bf_cookie;
    txs->txstatus[txs->cnt].ts_rate = SM(bf->bf_endpt, ATH9K_HTC_TXSTAT_EPID);

[olerem]

Hi, great catch! can you please make it officially with pull request.

[iazz]

Sure, here you are: #64.

[erikarn]

yay! Let's go review it.

-a

On 11 September 2014 05:31, Ignacy Gawędzki notifications@github.com wrote:

Sure, here you are: #64 https://github.com/qca/open-ath9k-htc-firmware/pull/64.

— Reply to this email directly or view it on GitHub https://github.com/qca/open-ath9k-htc-firmware/issues/63#issuecomment-55256765 .