search

qca / open-ath9k-htc-firmware

The firmware for QCA AR7010/AR9271 802.11n USB NICs
Other
429 stars 182 forks source link

Timestamp fix #67

Closed IanR778 closed 9 years ago

olerem commented 9 years ago

Ah, i see. You used code from ath9k driver.

Looks ok for me.

IanR778 commented 9 years ago

See updated fix and documentation.

IanR778 commented 9 years ago

Third time's a charm... Bugfix + added more test cases. Tested both in non-associated monitor mode (local TSF is running in open-loop mode), and associated (STATION) monitor mode (local TSF is locked to BSS TSF).

olerem commented 9 years ago

Hi, it will be better if you takes time and don't immediately sends new patches. If you wrote it today, then take a look on them tomorrow, probably you will find some thing worth of fixing. If the patches can't be split, plese merge them and provide proper description. If you do some comment to the function, then don't use this comment as 1x1 patch description.

IanR778 commented 9 years ago

I'm back, after having tested the final patch for more than a week now. This patch eliminates the occasional wrong timestamp that was occurring around TSF rollover (every ~72 minutes == 2^32 microseconds). It was tested by comparing the offset between remote vs. local TSF values using wireshark fields on beacon packets: "wlan_mgt.fixed.timestamp" and "radiotap.mactime". This test was conducted in two different configurations, one with AR9271 card locked to AP, and another AR9271 card with free-running TSF in monitor mode.

If you don't mind, I prefer closing this pull request, and sending 2 small pull requests (one for each file) instead. Is that OK with you?

olerem commented 9 years ago

Hi IanR778, do you have some updates?