qcastel / github-actions-maven-release

Release your Java application and publish artifacts
129 stars 38 forks source link

README typo - version increment #21

Closed awhitford closed 3 years ago

awhitford commented 3 years ago

Here: https://github.com/marketplace/actions/maven-release#increase-major-or-minor-version

By default, maven release will increase the path version.

I think you mean to say, "patch version."

qcastel commented 3 years ago

Yes, thats a typo, I meant patch.

Thanks for raising issues for helping getting this documentation more clear to everyone, much appreciate!

awhitford commented 3 years ago

There were 2 cases of path instead of patch. Please see: https://github.com/qcastel/github-actions-maven-release#features

Increment the major or minor version (by default, it's the path version that is increased)

qcastel commented 3 years ago

It's fixed too. thanks for checking my back!

Btw today I release an article on medium to show how to use this github actions using a sample app as demo: https://quentincastel86.medium.com/release-your-maven-project-using-github-actions-51beba1e4834 That may interest you if you are exploring the usage of this github action