search

qcastel / github-actions-maven-release

Release your Java application and publish artifacts
129 stars 38 forks source link

JDK 21 support as default #54

Closed dbelob closed 1 year ago

dbelob commented 1 year ago

Please add support for JDK 21 and make it the default version (JDK 21 released yesterday).

Now when I try to use Java 21 a error message appears:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile)
on project <module name>: Fatal error compiling: error: invalid target release: 21 -> [Help 1]

Thanks for the great GitHub Actions! I remember my promise ;)

qcastel commented 1 year ago

Added support to JDK 21 in https://github.com/qcastel/github-actions-maven-release/releases/tag/v1.12.40

Same spirit than before, simply update the JAVA_HOME: https://github.com/qcastel/github-actions-maven-release#jdk-21

All the best,

Quentin

dbelob commented 1 year ago

Added support to JDK 21 in https://github.com/qcastel/github-actions-maven-release/releases/tag/v1.12.40

I don't specify JAVA_HOME (I use the default JDK version) - action now completed without error, thanks a lot!

@qcastel Should JDK 21 be specified as the default JDK version in the JDK version section?

qcastel commented 1 year ago

Good catch! I updated the doc saying the default JDK is now 21.