search

qchateau / conan-center-bot

A bot to automatically update conan-center-index
GNU General Public License v3.0
11 stars 2 forks source link

Use Releases instead of Tags #106

Open ericLemanissier opened 1 year ago

ericLemanissier commented 1 year ago

Currently, conan-center-bot uses git tags to identify new version, and their download URLs. This is not ideal because more and more recipes are using release tarballs instead of git archives (this ensures sha stability). With the current stuation, Github and gitlab provide API to list releases and their artifact (eg https://gitlab.freedesktop.org/api/v4/projects/wayland%2Fwayland/releases and https://api.github.com/repos/openssl/openssl/releases). Using these API when available would:

The main problem is that both github and gitlab have rate limits on API. For github:

Gitlab rate limits are configurable per instance, so it's harder to have a clearer picture of what's possible.

Is it worth that I spend some time to implement these two new types of upstream and make a PR, or do you see a blocker right away ?

ericLemanissier commented 1 year ago

friendly ping @qchateau what's your take on the above ?

qchateau commented 1 year ago

I'm fine with adding support for more ways to find releases. IIRC I already use a GitHub token to find whether there are already open PR on CCI for a given update so there should be a way to reuse it, you don't have to do it yourself. Just make sure that breaching the rate limits doesn't crash the whole run - breaching the rate limit of the gitlab token should only prevent the recipes that rely on it from being auto-updated. For GitHub it's a bit more tricky because we need the token to detect open PRs, which impacts all recipes. But I suppose 1k request/hour give us some headroom

ericLemanissier commented 1 year ago

Ok, I should be able to see if/when/how rate-limit happens on my fork's workflow