search

qchateau / conan-center-bot

A bot to automatically update conan-center-index
GNU General Public License v3.0
11 stars 2 forks source link

Unable to create a PR from https://qchateau.github.io/conan-center-bot/#/updatable #111

Open EstebanDugueperoux2 opened 1 year ago

EstebanDugueperoux2 commented 1 year ago

Hi,

I'm unable to create a PR from https://qchateau.github.io/conan-center-bot/#/updatable. Trying to create a PR for libde265 I get a "Pull request creation failed. Validation failed: must be a collaborator" error message. See also comments from https://github.com/conan-io/conan-center-index/pull/18603#issuecomment-1640039576.

Regards.

jtbandes commented 1 year ago

I'm hitting the same error trying to create a PR for mcap: https://github.com/conan-io/conan-center-index/compare/conan-io:master...qchateau:ccb-mcap-1.2.0?expand=1

jtbandes commented 1 year ago

FWIW, cc @ericLemanissier - I get the same error when trying to use your fork as well. https://github.com/conan-io/conan-center-index/compare/conan-io:master...ericLemanissier:ccb-mcap-1.2.0?expand=1

image
ericLemanissier commented 1 year ago

OK. It must be that either CCI or github policy is refusing pull requests if the submitter is not contributor to the source repository.

qchateau commented 1 year ago

Yes it still works for me. I tried to change a few settings, can you retry from mine ? Else, try to fork my fork (...) and open your PR from there

ericLemanissier commented 1 year ago

Same error. Maybe it's because of Allowing edits by maintainers which is ticked by default?

jtbandes commented 1 year ago

I still get the same error too. It seems like it could be a GitHub policy. Would it make sense to enable the bot itself to submit a PR (perhaps only upon request)?

qchateau commented 1 year ago

CCI owners did not want me to automatically open Para, and doing it "upon request" doesn't seem super easy to implement without additional infrastructure

jtbandes commented 1 year ago

Do you think it's an issue with the upstream repo or with the fork? Maybe we should reach out to GitHub support to understand what the error really means by "must be a collaborator"?

ericLemanissier commented 1 year ago

This should be raised to github support yes. It happens when the person submitting the PR is not a collaborator to the fork being pulled, so the issue could originate in both the fork or the upstream.

jtbandes commented 1 year ago

I've opened a discussion here: https://github.com/orgs/community/discussions/61472

Dobiasd commented 9 months ago

And updates on this?