search

qchateau / conan-center-bot

A bot to automatically update conan-center-index
GNU General Public License v3.0
11 stars 2 forks source link

Bot failed to detect pr updating tinyspline #30

Open madebr opened 3 years ago

madebr commented 3 years ago

I opened a pr updating tinyspline yesterday at https://github.com/conan-io/conan-center-index/pull/3639. The bot has not picked up that pr the day after. Running conan-center-bot status also marks tinyspline as not updated:

| tinyspline         | 0.2.0          | 0.3.0       | v0.3.0                 | 0          |

Maybe this is because tinyspline changed its method of tagging releases? 0.2.0 was tagged as 0.2.0 and 0.3.0 as v0.3.0.

qchateau commented 3 years ago

The issue is that both the PR title and body refer to the upgrade as "0.3" instead "0.3.0", which is the string CCB is looking for.

Checking the actual PR content would require cloning and the repo and analyzing the diff (for every opened PR), which I think is both overly complicated and time consuking.

madebr commented 3 years ago

Ah thanks, I didn't know how you detected these things.

ericLemanissier commented 3 years ago

There a "lighter" way to do it: you can download the diff of a PR by using the diff_url property. This does not consume GH API credits,. You can then use https://github.com/matiasb/python-unidiff to analyse the change to conandata.yml files