ccb offers 'open pr' without testing valid configurations

qchateau / conan-center-bot

A bot to automatically update conan-center-index

GNU General Public License v3.0

11 stars 2 forks source link

ccb offers 'open pr' without testing valid configurations #43

Closed prince-chrismc closed 3 years ago

prince-chrismc commented 3 years ago

I got unlucky twice now https://github.com/conan-io/conan-center-index/pull/3705 and https://github.com/conan-io/conan-center-index/pull/3709

I think at a minimum it should try the PR at least one before appearing valid!

qchateau commented 3 years ago

What do you mean "try the PR" ? It already runs "conan create" with the latest hooks

prince-chrismc commented 3 years ago

Really?! dang you are good. I did not find where the result were posted... or what configuration(s) is ran... perhaps just note the information in the readme?

qchateau commented 3 years ago

It basically executes "conan create . @lib/x.x.x" on an ubuntu 20.04 image (provided by github actions) with an almost default config (I think I just configure conan to use libstdc++11)

I guess that information could be added to the website, let's leave this issue open as a reminder