qchateau / conan-center-bot

A bot to automatically update conan-center-index
GNU General Public License v3.0
11 stars 2 forks source link

fix update_status action on forks #58

Closed ericLemanissier closed 3 years ago

ericLemanissier commented 3 years ago

qchateau is also hard-coded several times in https://github.com/qchateau/conan-center-bot/blob/master/ccb/issue.py#L73 and https://github.com/qchateau/conan-center-bot/blob/master/ccb/update/common.py#L77. I'm not sure it worth the trouble modifying the python files to get the actual repo from the environment or command line

qchateau commented 3 years ago

Well it would be objectively better, though these env vars must be automatically defined by the workflow, and probably not required when using manually. Otherwise I agree it's too much trouble.

But I don't mind if you keep it hardcoded to qchateau. After all, it does not affect my repo :)

ericLemanissier commented 3 years ago

I don't really care about it any more