search

qchateau / conan-center-bot

A bot to automatically update conan-center-index
GNU General Public License v3.0
11 stars 2 forks source link

bump node version #79

Closed ericLemanissier closed 1 year ago

ericLemanissier commented 1 year ago

it fixes a warning: Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ https://github.com/qchateau/conan-center-bot/actions/runs/3261645063/jobs/5357006354

Another warning needs to be fixed : Theset-outputcommand is deprecated and will be disabled soon https://github.com/qchateau/conan-center-bot/actions/runs/3261645063/jobs/5357006354#step:3:11 which happens on line https://github.com/qchateau/conan-center-bot/blob/master/.github/workflows/ci.yml#L50 I'm not sure what the best way to fix this one. https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable recommends to write to $GITHUB_ENV file, but is it the best way to do it from a cmake script ? do you have a suggestion @qchateau

qchateau commented 1 year ago

Thank you for this. About that other warning, I don't know where I copy-pasted this from but this looks stupid. We don't need cmake to generate a timestamp... I suppose the step ccache_cache_timestamp could just use the shell and date to write to the $GITHUB_ENV file. And the next step could probably use the environment, although I don't exactly remember what can and cannot be done in GitHub actions.

ericLemanissier commented 1 year ago

ok, I generate it using bash now. What do you think ?

qchateau commented 1 year ago

Yep, looking good, thank you !