Closed fazal-e-majid closed 3 years ago
Thank you for your feedback, this is a bug and has been fixed. Update state when flipping
@qchenqizhi Thank you for fixing one part of the issue. Although the flip is working good independently but the bug is still there. The reset button has no effect on flip. And there is a case where Done button doesn’t work:
flip
.
-> Done
.
-> Next time just click Reset
. //( doesn’t resets flip ) => One.
-> Done
doesn’t work either. // => Two.@fazal-e-majid There should be no problem this time. 😅 Reset the flip state when reset
@qchenqizhi Thank you for creating this project and giving support ! ❤️
@qchenqizhi there’s another case where it’s not working as expected.
-> Apply just flip
.
-> Cancel
.
-> Reopen
the controller. // Image is already flipped.
@fazal-e-majid I cannot reproduce this problem, can you elaborate on the details of "Reopen"?
In addition, the current logic is: After Cancel
, this CropperViewController
needs to be discarded, so there is no reset work when Cancel
. If you need to reopen it, you need to pass a CropperState
to the init(originalImage: initialState)
method of CropperViewController
got you ! @qchenqizhi Thank you very much. ❤️❤️
@qchenqizhi Thank you for this beautiful library. I’m facing a bug that when I just flip the image and click done. and then when I come back with initial state and again change just flip, this time it’s not allowing me to click done. Is there no any support for flip in state management ?