search

qcif / data-curator

Data Curator - share usable open data
MIT License
264 stars 38 forks source link

On opening a data package json, success message is not shown #732

Open Stephen-Gates opened 6 years ago

Stephen-Gates commented 6 years ago

Current Behaviour

On opening a datapackage.zip I get a success message

screenshot 2018-04-27 07 33 05

This doesn't appear when opening a datapackage.json

Expected Behaviour

Consistent application messages

Environment

Data Curator v0.15.0

ghost commented 6 years ago

There'll probably be a couple of quirks like this. frictionless package load allows us to piggy back off this logic to pull out data package json and the resources - but we have to do it in main process, as browser is not supported. We still have to extract the properties and csv file parsing separately however. Have added much of this to existing logic that opens a new tab so it is present for all new data opens. For the remote zip, we already have a tested import in our renderer process - as frictionless do not yet support remote zips, just needed to add this to what we had and then run it through our normal unzip logic - hence why it has the correct messages etc already in place There is a little more work here to try to align these 2 separations.