search

qcod / laravel-app-settings

Store settings in database with a manager UI for your Laravel app
MIT License
338 stars 53 forks source link

Laravel Nova #5

Closed johannesschobel closed 6 years ago

johannesschobel commented 6 years ago

Hey @saqueib ,

that is quite a nice package - great work.. I have a suggestion, though.. Wouldn't it be better to "remove" the UI part in a separate package? This would, in turn, provide the functionality to add a laravel-nova package for creating the UI as well.

Because, actually, Laravel Nova provides most of the UI Builder functionality you have already created..

All the best and cheers

saqueib commented 6 years ago

thanks @johannesschobel,

Actually I created this packages since there is already some package which has DB persistence option. But all are lacking the UI which is a must for most of the app which I create.

Sure you can use it without the UI https://github.com/qcod/laravel-app-settings#use-without-ui

Laravel Nova is totally different concept and its paid 🤑 , its admin panel with Resource management and tons of other features. This one is for anybody who just needs a settings management system with UI.

saqueib commented 6 years ago

You know what, its good suggestion. Extracting storage layer to another package should not hurt. I will look into this and will do it in next version. 👍

johannesschobel commented 6 years ago

yeah, i know that it is paid.. however, i thought about splitting up the package into: 1) laravel-app-settings -> the "storage engine" 2) laravel-app-settings-ui-> the custom ui builder you have that consumes the laravel-app-settings storage engine 3) laravel-app-settings-nova -> a nova package that consumes the laravel-app-settings package

All the best

akiyamaSM commented 6 years ago

@johannesschobel @saqueib There is already a Laravel Nova version I made, has been released one day later https://github.com/akiyamaSM/laravel-nova-configuration its easy to use too.

saqueib commented 6 years ago

@akiyamaSM great. Now I am closing it since there is already a nova package for this

johannesschobel commented 6 years ago

yeah, but for future use it may be good to "split up" the package into a "ui" and "non-ui" version.. Because in API projects (with no direct UI) you will not need the UI Builder ;)

johannesschobel commented 6 years ago

@akiyamaSM the package you have mentioned does not use the laravel-app-setting package provided by this repository, right?! It is a complete stand-alone package, right?

saqueib commented 6 years ago

Sure, I will split this into storage and ui packages

akiyamaSM commented 6 years ago

@akiyamaSM the package you have mentioned does not use the laravel-app-setting package provided by this repository, right?! It is a complete stand-alone package, right?

Exactly, Its a stand alone app

saqueib commented 6 years ago

@johannesschobel As you suggested now this package has been split into two parts.

qcod/laravel-app-settings to keep the current API without any breaking changes and qcod/laravel-settings for a key-value pair in the database

johannesschobel commented 6 years ago

Thank you.. that is awesome news