qcode-software / qcode-ui

Qcode UI
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Mla 5473 leave site change #287

Closed PeterChaplin closed 1 year ago

PeterChaplin commented 1 year ago

See https://github.com/qcode-software/mla/issues/5473

Testing

bvw commented 1 year ago

What was the history behind this change?

PeterChaplin commented 1 year ago

In relation to https://github.com/qcode-software/mla/issues/5473 When a cell of type "bool" is given focus, the editor is initialised with the cell contents. This is triggering the editorValueChange event, which marks the row as dirty, which sets up the dbGrid onbeforeunload handler. When the user goes to navigate away, they get a "Leave Site?" dialog, despite not having made any changes. Other editor types do not have this behaviour, and only fire an editorValueChange event when the user changes the value of the input, not on initial load. I believe that this editor should do the same, and that the existing behaviour is a bug.