Issue: Looping not working properly

[StratoSTARbyHIRO]

On several different devices (Windows 7, Windows 8.1, Windows 10, Windows 10 XBSS, Android 7.0, and Other Proprietary Software), and on different browsers (Google Chrome, IE, Edge, Mozilla FireFox, and Proprietary HTML Browser) the looping function doesn't seem to be functioning properly.

I click/tap the TWC logo in the top left of the emulator, and nothing happens at all. I tried to force the "twcLogoClick" command in Google Chrome's console, and still nothing happens. The Autoplay Flags in Google Chrome have been changed appropriately.

Am I doing something wrong?

[relative2]

I can reproduce this on my fork and here. It appears the onclick event on the twc-logo element isn't being fired, as I tested by replacing it with console.log and it didn't log anything to the console when it was clicked.

[StratoSTARbyHIRO]

@FNCxPro I see! I'm glad I wasn't the only one experiencing this issue.

I have a question, regarding the looping. Is it intended to auto-start and continuously do that until stopped by the user, or is it just meant to show the settings again without refresh? Is there a way to get it to loop and auto-start (not requiring user input)?

[relative2]

It's intended to auto-start and continue on until you click the TWC logo again. Every end of the sequence, it will refresh the page and skip the settings page, since the settings are saved to the local storage (in browsers that support it, it might crash if the browser doesn't support it), the settings are loaded on every refresh before the sequence starts.

[StratoSTARbyHIRO]

@FNCxPro Okay, that sounds great! I do hope it's an easy fix, I looked through the file "Config.js" and spotted a line loop: false, and changed it to loop: true, and all it did for me, is show me the settings at the end of the allotted time instead of auto-start again.

[qconrad]

I made some changes. Let me know if it fixed in the newest version.

[StratoSTARbyHIRO]

@qconrad (as I cannot test other devices right now) On my Android 7.0 phone, running the latest Google Chrome with autoplay flags correct, it seems it doesn't refresh on it's own, however after the user refreshes it plays automatically. :)

I will test a few other devices when I'm free

[qconrad]

My bad. Didn't realize that was broken. Should be fixed now.

[relative2]

👍

Get Outlook for iOShttps://aka.ms/o0ukef

---

From: Quinn Conrad notifications@github.com Sent: Thursday, July 26, 2018 11:41:33 PM To: qconrad/intellistar-emulator Cc: Seth Stephens; Mention Subject: Re: [qconrad/intellistar-emulator] Issue: Looping not working properly (#11)

My bad. Didn't realize that was broken. Should be fixed now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/qconrad/intellistar-emulator/issues/11#issuecomment-408302453, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJEBNrRhZV9nv-STGS8LxSColgUCA2-oks5uKovtgaJpZM4Vh0R2.

[StratoSTARbyHIRO]

@qconrad I seems to be almost completely functional as of now, however it only refreshes it once, then after the second time it plays, it gets hung at the end, for an indefinite period of time and will not continue to refresh itself again and again as intended. (I am unsure if it just user error, or an error with my machines at this time.)

-EDIT- It seems if I now change loop: false, to loop: true, it no longer hangs and will infinitly run.

[qconrad]

Should work now without changing the config.

[StratoSTARbyHIRO]

@qconrad Yes! It's fully working now! Thanks for taking the time to make it right! 😄