search

qconrad / intellistar-emulator

A web application that displays weather information in the same visual presentation as the cable headend unit Intellistar.
https://qconrad.github.io/intellistar-emulator/
MIT License
89 stars 66 forks source link

Crawl Speed Tweaks #41

Closed rmitchellscott closed 1 year ago

rmitchellscott commented 1 year ago

This PR adjusts the logic of the calculateCrawlSpeed function to better handle short strings in the crawl.

It swaps to calculating animation time based on characters per second. There are three cases:

  1. Small string, low speed. Every string that will complete within the time the crawl bar is up should move at a consistent comfortable reading speed.
  2. Long string, high speed. Every string that cannot complete within the time the crawl bar is up should move at the fastest comfortable reading speed and is not expected to complete within the time the crawl bar is on-screen.
  3. In between. Medium-length strings should move at the slowest speed that allows them to complete while the crawl bar is on-screen.

Additionally, this PR hides the bar entirely if CONFIG.crawl (set either by config, interactively, or by alerts) is empty.

qconrad commented 1 year ago

My apologies for the delayed review. Happy to share that all your recent pull requests have now been merged. Thank you for your valuable contributions!

Halloween20 commented 1 year ago

Can you put in the Narrations Please ?